mirror of
https://github.com/nodejs/node.git
synced 2025-05-19 20:06:58 +00:00
15e136d9c5
A whole part of the test-http-agent-destroyed-socket test was not running as the semantics of http events changed slightly and were no longer triggering the expected event. Instead listen to the same event on the socket to verify that the code being tested is still working as expected. PR-URL: https://github.com/nodejs/node/pull/20006 Fixes: https://github.com/nodejs/node/issues/8613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
75 lines
3.0 KiB
JavaScript
75 lines
3.0 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
const Countdown = require('../common/countdown');
|
|
|
|
const server = http.createServer(common.mustCall((req, res) => {
|
|
res.writeHead(200, { 'Content-Type': 'text/plain' });
|
|
res.end('Hello World\n');
|
|
}, 2)).listen(0, common.mustCall(() => {
|
|
const agent = new http.Agent({ maxSockets: 1 });
|
|
|
|
agent.on('free', common.mustCall(3));
|
|
|
|
const requestOptions = {
|
|
agent: agent,
|
|
host: 'localhost',
|
|
port: server.address().port,
|
|
path: '/'
|
|
};
|
|
|
|
const request1 = http.get(requestOptions, common.mustCall((response) => {
|
|
// assert request2 is queued in the agent
|
|
const key = agent.getName(requestOptions);
|
|
assert.strictEqual(agent.requests[key].length, 1);
|
|
response.resume();
|
|
response.on('end', common.mustCall(() => {
|
|
request1.socket.destroy();
|
|
|
|
response.socket.once('close', common.mustCall(() => {
|
|
// assert request2 was removed from the queue
|
|
assert(!agent.requests[key]);
|
|
process.nextTick(() => {
|
|
// assert that the same socket was not assigned to request2,
|
|
// since it was destroyed.
|
|
assert.notStrictEqual(request1.socket, request2.socket);
|
|
assert(!request2.socket.destroyed, 'the socket is destroyed');
|
|
});
|
|
}));
|
|
}));
|
|
}));
|
|
|
|
const request2 = http.get(requestOptions, common.mustCall((response) => {
|
|
assert(!request2.socket.destroyed);
|
|
assert(request1.socket.destroyed);
|
|
// assert not reusing the same socket, since it was destroyed.
|
|
assert.notStrictEqual(request1.socket, request2.socket);
|
|
const countdown = new Countdown(2, () => server.close());
|
|
request2.socket.on('close', common.mustCall(() => countdown.dec()));
|
|
response.on('end', common.mustCall(() => countdown.dec()));
|
|
response.resume();
|
|
}));
|
|
}));
|