mirror of
https://github.com/nodejs/node.git
synced 2025-05-19 20:06:58 +00:00
3c62f33d7b
1. Among the list of Code and Learn, I solved the unfinished task of replacing function with arrow function: https://github.com/nodejs/code-and-learn/issues/72#issuecomment-345667395 2. Replace arrow function with shorter property syntax Arrow function makes `this` lexical scope. But toString expects evaluate `this` in runtime. 3. Replace this with null makeBlock does not need `this`. update `this` with `null` to clarify the intent. PR-URL: https://github.com/nodejs/node/pull/17345 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
35 lines
1.2 KiB
JavaScript
35 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const domain = require('domain');
|
|
|
|
/*
|
|
* Make sure that the domains stack is cleared after a top-level domain
|
|
* error handler exited gracefully.
|
|
*/
|
|
const d = domain.create();
|
|
|
|
d.on('error', common.mustCall(() => {
|
|
process.nextTick(() => {
|
|
// Scheduling a callback with process.nextTick will enter a _new_ domain,
|
|
// and the callback will be called after the domain that handled the error
|
|
// was exited. So there should be only one domain on the domains stack if
|
|
// the domains stack was cleared properly when the domain error handler
|
|
// returned.
|
|
if (domain._stack.length !== 1) {
|
|
// Do not use assert to perform this test: this callback runs in a
|
|
// different callstack as the original process._fatalException that
|
|
// handled the original error, thus throwing here would trigger another
|
|
// call to process._fatalException, and so on recursively and
|
|
// indefinitely.
|
|
console.error('domains stack length should be 1, but instead is:',
|
|
domain._stack.length);
|
|
process.exit(1);
|
|
}
|
|
});
|
|
}));
|
|
|
|
d.run(() => {
|
|
throw new Error('Error from domain');
|
|
});
|