mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 08:33:17 +00:00
0fd4c73e5c
In the case where triggerAsyncId is null it should default to the current executionAsyncId. This worked but as a side-effect the resource object was changed too. This fix also makes the null check more strict. EmitInitS is not a documented API, thus there is no reason to be flexible in its input. Ref: https://github.com/nodejs/node/issues/13548#issuecomment-310985270 PR-URL: https://github.com/nodejs/node/pull/14026 Reviewed-By: Refael Ackermann <refack@gmail.com>
50 lines
1.7 KiB
JavaScript
50 lines
1.7 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const async_hooks = require('async_hooks');
|
|
const initHooks = require('./init-hooks');
|
|
|
|
// Verify that if there is no registered hook, then those invalid parameters
|
|
// won't be checked.
|
|
assert.doesNotThrow(() => async_hooks.emitInit());
|
|
|
|
const expectedId = async_hooks.newUid();
|
|
const expectedTriggerId = async_hooks.newUid();
|
|
const expectedType = 'test_emit_init_type';
|
|
const expectedResource = { key: 'test_emit_init_resource' };
|
|
|
|
const hooks1 = initHooks({
|
|
oninit: common.mustCall((id, type, triggerAsyncId, resource) => {
|
|
assert.strictEqual(id, expectedId);
|
|
assert.strictEqual(type, expectedType);
|
|
assert.strictEqual(triggerAsyncId, expectedTriggerId);
|
|
assert.strictEqual(resource.key, expectedResource.key);
|
|
})
|
|
});
|
|
|
|
hooks1.enable();
|
|
|
|
assert.throws(() => async_hooks.emitInit(),
|
|
/^RangeError: asyncId must be an unsigned integer$/);
|
|
assert.throws(() => async_hooks.emitInit(expectedId),
|
|
/^TypeError: type must be a string with length > 0$/);
|
|
assert.throws(() => async_hooks.emitInit(expectedId, expectedType, -1),
|
|
/^RangeError: triggerAsyncId must be an unsigned integer$/);
|
|
|
|
async_hooks.emitInit(expectedId, expectedType, expectedTriggerId,
|
|
expectedResource);
|
|
|
|
hooks1.disable();
|
|
|
|
initHooks({
|
|
oninit: common.mustCall((id, type, triggerAsyncId, resource) => {
|
|
assert.strictEqual(id, expectedId);
|
|
assert.strictEqual(type, expectedType);
|
|
assert.notStrictEqual(triggerAsyncId, expectedTriggerId);
|
|
assert.strictEqual(resource.key, expectedResource.key);
|
|
})
|
|
}).enable();
|
|
|
|
async_hooks.emitInit(expectedId, expectedType, null, expectedResource);
|