mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 05:41:13 +00:00

test-repl-tab-complete includes tests that ensure that certain keys do not appear in tab completions or that completion does not crash the repl. It performed these tests by comparing completion output to a hardcoded list of expected keys. This list is made incorrect by any api changes that occur when new versions of V8 are introduced. With this change, we assert that the specific keys to be avoided are not present in the output instead. PR-URL: https://github.com/nodejs/node/pull/5772 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
252 lines
6.2 KiB
JavaScript
252 lines
6.2 KiB
JavaScript
'use strict';
|
|
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var repl = require('repl');
|
|
var referenceErrors = 0;
|
|
var expectedReferenceErrors = 0;
|
|
|
|
function getDoNotCallFunction() {
|
|
expectedReferenceErrors += 1;
|
|
return function() {
|
|
assert(false);
|
|
};
|
|
}
|
|
|
|
process.on('exit', function() {
|
|
assert.strictEqual(referenceErrors, expectedReferenceErrors);
|
|
});
|
|
|
|
var works = [['inner.one'], 'inner.o'];
|
|
const putIn = new common.ArrayStream();
|
|
var testMe = repl.start('', putIn);
|
|
|
|
// Some errors are passed to the domain, but do not callback
|
|
testMe._domain.on('error', function(err) {
|
|
// Errors come from another context, so instanceof doesn't work
|
|
var str = err.toString();
|
|
|
|
if (/^ReferenceError:/.test(str))
|
|
referenceErrors++;
|
|
else
|
|
assert(false);
|
|
});
|
|
|
|
// Tab Complete will not break in an object literal
|
|
putIn.run(['.clear']);
|
|
putIn.run([
|
|
'var inner = {',
|
|
'one:1'
|
|
]);
|
|
testMe.complete('inner.o', getDoNotCallFunction());
|
|
|
|
testMe.complete('console.lo', common.mustCall(function(error, data) {
|
|
assert.deepEqual(data, [['console.log'], 'console.lo']);
|
|
}));
|
|
|
|
// Tab Complete will return globaly scoped variables
|
|
putIn.run(['};']);
|
|
testMe.complete('inner.o', common.mustCall(function(error, data) {
|
|
assert.deepEqual(data, works);
|
|
}));
|
|
|
|
putIn.run(['.clear']);
|
|
|
|
// Tab Complete will not break in an ternary operator with ()
|
|
putIn.run([
|
|
'var inner = ( true ',
|
|
'?',
|
|
'{one: 1} : '
|
|
]);
|
|
testMe.complete('inner.o', getDoNotCallFunction());
|
|
|
|
putIn.run(['.clear']);
|
|
|
|
// Tab Complete will return a simple local variable
|
|
putIn.run([
|
|
'var top = function() {',
|
|
'var inner = {one:1};'
|
|
]);
|
|
testMe.complete('inner.o', common.mustCall(function(error, data) {
|
|
assert.deepEqual(data, works);
|
|
}));
|
|
|
|
// When you close the function scope tab complete will not return the
|
|
// locally scoped variable
|
|
putIn.run(['};']);
|
|
testMe.complete('inner.o', getDoNotCallFunction());
|
|
|
|
putIn.run(['.clear']);
|
|
|
|
// Tab Complete will return a complex local variable
|
|
putIn.run([
|
|
'var top = function() {',
|
|
'var inner = {',
|
|
' one:1',
|
|
'};'
|
|
]);
|
|
testMe.complete('inner.o', common.mustCall(function(error, data) {
|
|
assert.deepEqual(data, works);
|
|
}));
|
|
|
|
putIn.run(['.clear']);
|
|
|
|
// Tab Complete will return a complex local variable even if the function
|
|
// has parameters
|
|
putIn.run([
|
|
'var top = function(one, two) {',
|
|
'var inner = {',
|
|
' one:1',
|
|
'};'
|
|
]);
|
|
testMe.complete('inner.o', common.mustCall(function(error, data) {
|
|
assert.deepEqual(data, works);
|
|
}));
|
|
|
|
putIn.run(['.clear']);
|
|
|
|
// Tab Complete will return a complex local variable even if the
|
|
// scope is nested inside an immediately executed function
|
|
putIn.run([
|
|
'var top = function() {',
|
|
'(function test () {',
|
|
'var inner = {',
|
|
' one:1',
|
|
'};'
|
|
]);
|
|
testMe.complete('inner.o', common.mustCall(function(error, data) {
|
|
assert.deepEqual(data, works);
|
|
}));
|
|
|
|
putIn.run(['.clear']);
|
|
|
|
// def has the params and { on a separate line
|
|
putIn.run([
|
|
'var top = function() {',
|
|
'r = function test (',
|
|
' one, two) {',
|
|
'var inner = {',
|
|
' one:1',
|
|
'};'
|
|
]);
|
|
testMe.complete('inner.o', getDoNotCallFunction());
|
|
|
|
putIn.run(['.clear']);
|
|
|
|
// currently does not work, but should not break, not the {
|
|
putIn.run([
|
|
'var top = function() {',
|
|
'r = function test ()',
|
|
'{',
|
|
'var inner = {',
|
|
' one:1',
|
|
'};'
|
|
]);
|
|
testMe.complete('inner.o', getDoNotCallFunction());
|
|
|
|
putIn.run(['.clear']);
|
|
|
|
// currently does not work, but should not break
|
|
putIn.run([
|
|
'var top = function() {',
|
|
'r = function test (',
|
|
')',
|
|
'{',
|
|
'var inner = {',
|
|
' one:1',
|
|
'};'
|
|
]);
|
|
testMe.complete('inner.o', getDoNotCallFunction());
|
|
|
|
putIn.run(['.clear']);
|
|
|
|
// make sure tab completion works on non-Objects
|
|
putIn.run([
|
|
'var str = "test";'
|
|
]);
|
|
testMe.complete('str.len', common.mustCall(function(error, data) {
|
|
assert.deepEqual(data, [['str.length'], 'str.len']);
|
|
}));
|
|
|
|
putIn.run(['.clear']);
|
|
|
|
// tab completion should not break on spaces
|
|
var spaceTimeout = setTimeout(function() {
|
|
throw new Error('timeout');
|
|
}, 1000);
|
|
|
|
testMe.complete(' ', common.mustCall(function(error, data) {
|
|
assert.deepEqual(data, [[], undefined]);
|
|
clearTimeout(spaceTimeout);
|
|
}));
|
|
|
|
// tab completion should pick up the global "toString" object, and
|
|
// any other properties up the "global" object's prototype chain
|
|
testMe.complete('toSt', common.mustCall(function(error, data) {
|
|
assert.deepEqual(data, [['toString'], 'toSt']);
|
|
}));
|
|
|
|
// Tab complete provides built in libs for require()
|
|
putIn.run(['.clear']);
|
|
|
|
testMe.complete('require(\'', common.mustCall(function(error, data) {
|
|
assert.strictEqual(error, null);
|
|
repl._builtinLibs.forEach(function(lib) {
|
|
assert.notStrictEqual(data[0].indexOf(lib), -1, lib + ' not found');
|
|
});
|
|
}));
|
|
|
|
testMe.complete('require(\'n', common.mustCall(function(error, data) {
|
|
assert.strictEqual(error, null);
|
|
assert.strictEqual(data.length, 2);
|
|
assert.strictEqual(data[1], 'n');
|
|
assert.notStrictEqual(data[0].indexOf('net'), -1);
|
|
// It's possible to pick up non-core modules too
|
|
data[0].forEach(function(completion) {
|
|
if (completion)
|
|
assert(/^n/.test(completion));
|
|
});
|
|
}));
|
|
|
|
// Make sure tab completion works on context properties
|
|
putIn.run(['.clear']);
|
|
|
|
putIn.run([
|
|
'var custom = "test";'
|
|
]);
|
|
testMe.complete('cus', common.mustCall(function(error, data) {
|
|
assert.deepEqual(data, [['custom'], 'cus']);
|
|
}));
|
|
|
|
// Make sure tab completion doesn't crash REPL with half-baked proxy objects.
|
|
// See: https://github.com/nodejs/node/issues/2119
|
|
putIn.run(['.clear']);
|
|
|
|
putIn.run([
|
|
'var proxy = new Proxy({}, {ownKeys: () => { throw new Error(); }});'
|
|
]);
|
|
|
|
testMe.complete('proxy.', common.mustCall(function(error, data) {
|
|
assert.strictEqual(error, null);
|
|
}));
|
|
|
|
// Make sure tab completion does not include integer members of an Array
|
|
putIn.run(['.clear']);
|
|
|
|
putIn.run(['var ary = [1,2,3];']);
|
|
testMe.complete('ary.', common.mustCall(function(error, data) {
|
|
assert.strictEqual(data[0].indexOf('ary.0'), -1);
|
|
assert.strictEqual(data[0].indexOf('ary.1'), -1);
|
|
assert.strictEqual(data[0].indexOf('ary.2'), -1);
|
|
}));
|
|
|
|
// Make sure tab completion does not include integer keys in an object
|
|
putIn.run(['.clear']);
|
|
putIn.run(['var obj = {1:"a","1a":"b",a:"b"};']);
|
|
|
|
testMe.complete('obj.', common.mustCall(function(error, data) {
|
|
assert.strictEqual(data[0].indexOf('obj.1'), -1);
|
|
assert.strictEqual(data[0].indexOf('obj.1a'), -1);
|
|
assert.notStrictEqual(data[0].indexOf('obj.a'), -1);
|
|
}));
|