mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 15:41:06 +00:00
0bbda5e5ae
Since v10.10.0, 'buf' can be any DataView, meaning the largest byteLength can be Float64Array.BYTES_PER_ELEMENT * kMaxLength = 17,179,869,176. 'offset' can now be up to 2**53 - 1. This makes it possible to tile reads into a large buffer. Breaking: now throws if read offset is not a safe int, is null or is undefined. Fixes https://github.com/nodejs/node/issues/26563 PR-URL: https://github.com/nodejs/node/pull/26572 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
145 lines
3.6 KiB
JavaScript
145 lines
3.6 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const fs = require('fs');
|
|
const assert = require('assert');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const filepath = fixtures.path('x.txt');
|
|
const fd = fs.openSync(filepath, 'r');
|
|
const expected = 'xyz\n';
|
|
|
|
|
|
// Error must be thrown with string
|
|
assert.throws(
|
|
() => fs.read(fd, expected.length, 0, 'utf-8', common.mustNotCall()),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "buffer" argument must be one of type Buffer, TypedArray, ' +
|
|
'or DataView. Received type number'
|
|
}
|
|
);
|
|
|
|
[true, null, undefined, () => {}, {}].forEach((value) => {
|
|
assert.throws(() => {
|
|
fs.read(value,
|
|
Buffer.allocUnsafe(expected.length),
|
|
0,
|
|
expected.length,
|
|
0,
|
|
common.mustNotCall());
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "fd" argument must be of type number. ' +
|
|
`Received type ${typeof value}`
|
|
});
|
|
});
|
|
|
|
assert.throws(() => {
|
|
fs.read(fd,
|
|
Buffer.allocUnsafe(expected.length),
|
|
-1,
|
|
expected.length,
|
|
0,
|
|
common.mustNotCall());
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "offset" is out of range. It must be >= 0 && <= 4. ' +
|
|
'Received -1'
|
|
});
|
|
|
|
assert.throws(() => {
|
|
fs.read(fd,
|
|
Buffer.allocUnsafe(expected.length),
|
|
NaN,
|
|
expected.length,
|
|
0,
|
|
common.mustNotCall());
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "offset" is out of range. It must be an integer. ' +
|
|
'Received NaN'
|
|
});
|
|
|
|
assert.throws(() => {
|
|
fs.read(fd,
|
|
Buffer.allocUnsafe(expected.length),
|
|
0,
|
|
-1,
|
|
0,
|
|
common.mustNotCall());
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "length" is out of range. ' +
|
|
'It must be >= 0 && <= 4. Received -1'
|
|
});
|
|
|
|
|
|
assert.throws(
|
|
() => fs.readSync(fd, expected.length, 0, 'utf-8'),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "buffer" argument must be one of type Buffer, TypedArray, ' +
|
|
'or DataView. Received type number'
|
|
}
|
|
);
|
|
|
|
[true, null, undefined, () => {}, {}].forEach((value) => {
|
|
assert.throws(() => {
|
|
fs.readSync(value,
|
|
Buffer.allocUnsafe(expected.length),
|
|
0,
|
|
expected.length,
|
|
0);
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "fd" argument must be of type number. ' +
|
|
`Received type ${typeof value}`
|
|
});
|
|
});
|
|
|
|
assert.throws(() => {
|
|
fs.readSync(fd,
|
|
Buffer.allocUnsafe(expected.length),
|
|
-1,
|
|
expected.length,
|
|
0);
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "offset" is out of range. ' +
|
|
'It must be >= 0 && <= 4. Received -1'
|
|
});
|
|
|
|
assert.throws(() => {
|
|
fs.readSync(fd,
|
|
Buffer.allocUnsafe(expected.length),
|
|
NaN,
|
|
expected.length,
|
|
0);
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "offset" is out of range. It must be an integer. ' +
|
|
'Received NaN'
|
|
});
|
|
|
|
assert.throws(() => {
|
|
fs.readSync(fd,
|
|
Buffer.allocUnsafe(expected.length),
|
|
0,
|
|
-1,
|
|
0);
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "length" is out of range. ' +
|
|
'It must be >= 0 && <= 4. Received -1'
|
|
});
|