mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 07:19:19 +00:00
0bb70b0a02
These tests were written a long time ago, and use the allocation of large amounts of unused memory as a way to detect use-after-free problems with Buffers. As a result, the tests are resource-intensive and may crash because of that. Replace them with a more modern test. We don’t explicitly try to *detect* use-after-free conditions, and instead rely on e.g. ASAN (or the process just crashing hard) to do that for us. Fixes: https://github.com/nodejs/node/issues/34527 PR-URL: https://github.com/nodejs/node/pull/34530 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
40 lines
993 B
JavaScript
40 lines
993 B
JavaScript
// Flags: --expose-gc
|
|
'use strict';
|
|
const common = require('../common');
|
|
const tmpdir = require('../common/tmpdir');
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
|
|
// Regression test for https://github.com/nodejs/node-v0.x-archive/issues/814:
|
|
// Make sure that Buffers passed to fs.write() are not garbage-collected
|
|
// even when the callback is being reused.
|
|
|
|
const fs = require('fs');
|
|
|
|
tmpdir.refresh();
|
|
const filename = path.join(tmpdir.path, 'test.txt');
|
|
const fd = fs.openSync(filename, 'w');
|
|
|
|
const size = 16 * 1024;
|
|
const writes = 1000;
|
|
let done = 0;
|
|
|
|
const ondone = common.mustCall((err) => {
|
|
assert.ifError(err);
|
|
if (++done < writes) {
|
|
if (done % 25 === 0) global.gc();
|
|
setImmediate(write);
|
|
} else {
|
|
assert.strictEqual(
|
|
fs.readFileSync(filename, 'utf8'),
|
|
'x'.repeat(writes * size));
|
|
fs.closeSync(fd);
|
|
}
|
|
}, writes);
|
|
|
|
write();
|
|
function write() {
|
|
const buf = Buffer.alloc(size, 'x');
|
|
fs.write(fd, buf, 0, buf.size, -1, ondone);
|
|
}
|