node/test/parallel/test-http2-server-shutdown-options-errors.js
James M Snell 0babd181a0 http2: cleanup Http2Stream/Http2Session destroy
PR-URL: https://github.com/nodejs/node/pull/17406
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

This is a significant cleanup and refactoring of the
cleanup/close/destroy logic for Http2Stream and Http2Session.
There are significant changes here in the timing and ordering
of cleanup logic, JS apis. and various related necessary edits.
2017-12-18 10:19:21 -08:00

70 lines
1.7 KiB
JavaScript

'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const server = http2.createServer();
const types = [
true,
{},
[],
null,
new Date()
];
server.on('stream', common.mustCall((stream) => {
const session = stream.session;
types.forEach((i) => {
common.expectsError(
() => session.goaway(i),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "code" argument must be of type number'
}
);
common.expectsError(
() => session.goaway(0, i),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "lastStreamID" argument must be of type number'
}
);
common.expectsError(
() => session.goaway(0, 0, i),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "opaqueData" argument must be one of type Buffer, ' +
'TypedArray, or DataView'
}
);
});
stream.session.destroy();
}));
server.listen(
0,
common.mustCall(() => {
const client = http2.connect(`http://localhost:${server.address().port}`);
// On certain operating systems, an ECONNRESET may occur. We do not need
// to test for it here. Do not make this a mustCall
client.on('error', () => {});
const req = client.request();
// On certain operating systems, an ECONNRESET may occur. We do not need
// to test for it here. Do not make this a mustCall
req.on('error', () => {});
req.resume();
req.on('close', common.mustCall(() => {
client.close();
server.close();
}));
})
);