mirror of
https://github.com/nodejs/node.git
synced 2025-05-08 23:23:46 +00:00

PR-URL: https://github.com/nodejs/node/pull/17406 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> This is a significant cleanup and refactoring of the cleanup/close/destroy logic for Http2Stream and Http2Session. There are significant changes here in the timing and ordering of cleanup logic, JS apis. and various related necessary edits.
55 lines
1.4 KiB
JavaScript
55 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
|
|
const server = http2.createServer();
|
|
|
|
server.on('session', common.mustCall((session) => {
|
|
// Verify that the settings disabling push is received
|
|
session.on('remoteSettings', common.mustCall((settings) => {
|
|
assert.strictEqual(settings.enablePush, false);
|
|
}));
|
|
}));
|
|
|
|
server.on('stream', common.mustCall((stream) => {
|
|
|
|
// The client has disabled push streams, so pushAllowed must be false,
|
|
// and pushStream() must throw.
|
|
assert.strictEqual(stream.pushAllowed, false);
|
|
|
|
common.expectsError(() => {
|
|
stream.pushStream({
|
|
':scheme': 'http',
|
|
':path': '/foobar',
|
|
':authority': `localhost:${server.address().port}`,
|
|
}, common.mustNotCall());
|
|
}, {
|
|
code: 'ERR_HTTP2_PUSH_DISABLED',
|
|
type: Error
|
|
});
|
|
|
|
stream.respond({ ':status': 200 });
|
|
stream.end('test');
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const options = { settings: { enablePush: false } };
|
|
const client = http2.connect(`http://localhost:${server.address().port}`,
|
|
options);
|
|
const req = client.request({ ':path': '/' });
|
|
|
|
// Because push stream sre disabled, this must not be called.
|
|
client.on('stream', common.mustNotCall());
|
|
|
|
req.resume();
|
|
req.on('end', common.mustCall(() => {
|
|
server.close();
|
|
client.close();
|
|
}));
|
|
req.end();
|
|
}));
|