mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 13:47:16 +00:00
0babd181a0
PR-URL: https://github.com/nodejs/node/pull/17406 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> This is a significant cleanup and refactoring of the cleanup/close/destroy logic for Http2Stream and Http2Session. There are significant changes here in the timing and ordering of cleanup logic, JS apis. and various related necessary edits.
87 lines
2.1 KiB
JavaScript
87 lines
2.1 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
|
|
// Errors should not be reported both in Http2ServerRequest
|
|
// and Http2ServerResponse
|
|
|
|
{
|
|
let expected = null;
|
|
|
|
const server = h2.createServer();
|
|
|
|
server.on('stream', common.mustCall(function(stream) {
|
|
stream.on('error', common.mustCall(function(err) {
|
|
assert.strictEqual(err, expected);
|
|
}));
|
|
|
|
stream.resume();
|
|
stream.write('hello');
|
|
|
|
expected = new Error('kaboom');
|
|
stream.destroy(expected);
|
|
server.close();
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(function() {
|
|
const port = server.address().port;
|
|
|
|
const url = `http://localhost:${port}`;
|
|
const client = h2.connect(url, common.mustCall(function() {
|
|
const headers = {
|
|
':path': '/foobar',
|
|
':method': 'GET',
|
|
':scheme': 'http',
|
|
':authority': `localhost:${port}`,
|
|
};
|
|
const request = client.request(headers);
|
|
request.on('data', common.mustCall(function(chunk) {
|
|
// cause an error on the server side
|
|
client.destroy();
|
|
}));
|
|
request.end();
|
|
}));
|
|
}));
|
|
}
|
|
|
|
{
|
|
let expected = null;
|
|
|
|
const server = h2.createServer();
|
|
|
|
server.on('stream', common.mustCall(function(stream) {
|
|
// there is no 'error' handler, and this will not crash
|
|
stream.write('hello');
|
|
stream.resume();
|
|
|
|
expected = new Error('kaboom');
|
|
stream.destroy(expected);
|
|
server.close();
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(function() {
|
|
const port = server.address().port;
|
|
|
|
const url = `http://localhost:${port}`;
|
|
const client = h2.connect(url, common.mustCall(function() {
|
|
const headers = {
|
|
':path': '/foobar',
|
|
':method': 'GET',
|
|
':scheme': 'http',
|
|
':authority': `localhost:${port}`,
|
|
};
|
|
const request = client.request(headers);
|
|
request.on('data', common.mustCall(function(chunk) {
|
|
// cause an error on the server side
|
|
client.destroy();
|
|
}));
|
|
request.end();
|
|
}));
|
|
}));
|
|
}
|