mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 19:38:23 +00:00

PR-URL: https://github.com/nodejs/node/pull/17406 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> This is a significant cleanup and refactoring of the cleanup/close/destroy logic for Http2Stream and Http2Session. There are significant changes here in the timing and ordering of cleanup logic, JS apis. and various related necessary edits.
188 lines
5.6 KiB
JavaScript
188 lines
5.6 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
|
|
// Http2ServerResponse should support checking and reading custom headers
|
|
|
|
const server = h2.createServer();
|
|
server.listen(0, common.mustCall(function() {
|
|
const port = server.address().port;
|
|
server.once('request', common.mustCall(function(request, response) {
|
|
const real = 'foo-bar';
|
|
const fake = 'bar-foo';
|
|
const denormalised = ` ${real.toUpperCase()}\n\t`;
|
|
const expectedValue = 'abc123';
|
|
|
|
response.setHeader(real, expectedValue);
|
|
|
|
assert.strictEqual(response.hasHeader(real), true);
|
|
assert.strictEqual(response.hasHeader(fake), false);
|
|
assert.strictEqual(response.hasHeader(denormalised), true);
|
|
assert.strictEqual(response.getHeader(real), expectedValue);
|
|
assert.strictEqual(response.getHeader(denormalised), expectedValue);
|
|
assert.strictEqual(response.getHeader(fake), undefined);
|
|
|
|
response.removeHeader(fake);
|
|
assert.strictEqual(response.hasHeader(fake), false);
|
|
|
|
response.setHeader(real, expectedValue);
|
|
assert.strictEqual(response.getHeader(real), expectedValue);
|
|
assert.strictEqual(response.hasHeader(real), true);
|
|
response.removeHeader(real);
|
|
assert.strictEqual(response.hasHeader(real), false);
|
|
|
|
response.setHeader(denormalised, expectedValue);
|
|
assert.strictEqual(response.getHeader(denormalised), expectedValue);
|
|
assert.strictEqual(response.hasHeader(denormalised), true);
|
|
response.removeHeader(denormalised);
|
|
assert.strictEqual(response.hasHeader(denormalised), false);
|
|
|
|
common.expectsError(
|
|
() => response.hasHeader(),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "name" argument must be of type string'
|
|
}
|
|
);
|
|
common.expectsError(
|
|
() => response.getHeader(),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "name" argument must be of type string'
|
|
}
|
|
);
|
|
common.expectsError(
|
|
() => response.removeHeader(),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "name" argument must be of type string'
|
|
}
|
|
);
|
|
|
|
[
|
|
':status',
|
|
':method',
|
|
':path',
|
|
':authority',
|
|
':scheme'
|
|
].forEach((header) => common.expectsError(
|
|
() => response.setHeader(header, 'foobar'),
|
|
{
|
|
code: 'ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED',
|
|
type: Error,
|
|
message: 'Cannot set HTTP/2 pseudo-headers'
|
|
})
|
|
);
|
|
common.expectsError(function() {
|
|
response.setHeader(real, null);
|
|
}, {
|
|
code: 'ERR_HTTP2_INVALID_HEADER_VALUE',
|
|
type: TypeError,
|
|
message: 'Invalid value "null" for header "foo-bar"'
|
|
});
|
|
common.expectsError(function() {
|
|
response.setHeader(real, undefined);
|
|
}, {
|
|
code: 'ERR_HTTP2_INVALID_HEADER_VALUE',
|
|
type: TypeError,
|
|
message: 'Invalid value "undefined" for header "foo-bar"'
|
|
});
|
|
common.expectsError(
|
|
() => response.setHeader(), // header name undefined
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "name" argument must be of type string'
|
|
}
|
|
);
|
|
common.expectsError(
|
|
() => response.setHeader(''),
|
|
{
|
|
code: 'ERR_INVALID_HTTP_TOKEN',
|
|
type: TypeError,
|
|
message: 'Header name must be a valid HTTP token [""]'
|
|
}
|
|
);
|
|
|
|
response.setHeader(real, expectedValue);
|
|
const expectedHeaderNames = [real];
|
|
assert.deepStrictEqual(response.getHeaderNames(), expectedHeaderNames);
|
|
const expectedHeaders = { [real]: expectedValue };
|
|
assert.deepStrictEqual(response.getHeaders(), expectedHeaders);
|
|
|
|
response.getHeaders()[fake] = fake;
|
|
assert.strictEqual(response.hasHeader(fake), false);
|
|
|
|
assert.strictEqual(response.sendDate, true);
|
|
response.sendDate = false;
|
|
assert.strictEqual(response.sendDate, false);
|
|
|
|
response.on('finish', common.mustCall(function() {
|
|
assert.strictEqual(response.headersSent, true);
|
|
|
|
common.expectsError(
|
|
() => response.setHeader(real, expectedValue),
|
|
{
|
|
code: 'ERR_HTTP2_HEADERS_SENT',
|
|
type: Error,
|
|
message: 'Response has already been initiated.'
|
|
}
|
|
);
|
|
common.expectsError(
|
|
() => response.removeHeader(real, expectedValue),
|
|
{
|
|
code: 'ERR_HTTP2_HEADERS_SENT',
|
|
type: Error,
|
|
message: 'Response has already been initiated.'
|
|
}
|
|
);
|
|
|
|
process.nextTick(() => {
|
|
common.expectsError(
|
|
() => response.setHeader(real, expectedValue),
|
|
{
|
|
code: 'ERR_HTTP2_HEADERS_SENT',
|
|
type: Error,
|
|
message: 'Response has already been initiated.'
|
|
}
|
|
);
|
|
common.expectsError(
|
|
() => response.removeHeader(real, expectedValue),
|
|
{
|
|
code: 'ERR_HTTP2_HEADERS_SENT',
|
|
type: Error,
|
|
message: 'Response has already been initiated.'
|
|
}
|
|
);
|
|
|
|
assert.strictEqual(response.headersSent, true);
|
|
server.close();
|
|
});
|
|
}));
|
|
response.end();
|
|
}));
|
|
|
|
const url = `http://localhost:${port}`;
|
|
const client = h2.connect(url, common.mustCall(function() {
|
|
const headers = {
|
|
':path': '/',
|
|
':method': 'GET',
|
|
':scheme': 'http',
|
|
':authority': `localhost:${port}`
|
|
};
|
|
const request = client.request(headers);
|
|
request.on('end', common.mustCall(function() {
|
|
client.close();
|
|
}));
|
|
request.end();
|
|
request.resume();
|
|
}));
|
|
}));
|