mirror of
https://github.com/nodejs/node.git
synced 2025-05-08 02:52:29 +00:00
0babd181a0
PR-URL: https://github.com/nodejs/node/pull/17406 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> This is a significant cleanup and refactoring of the cleanup/close/destroy logic for Http2Stream and Http2Session. There are significant changes here in the timing and ordering of cleanup logic, JS apis. and various related necessary edits.
88 lines
2.5 KiB
JavaScript
88 lines
2.5 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
|
|
// Http2ServerRequest should have header helpers
|
|
|
|
const server = h2.createServer();
|
|
server.listen(0, common.mustCall(function() {
|
|
const port = server.address().port;
|
|
server.once('request', common.mustCall(function(request, response) {
|
|
const expected = {
|
|
':path': '/foobar',
|
|
':method': 'GET',
|
|
':scheme': 'http',
|
|
':authority': `localhost:${port}`,
|
|
'foo-bar': 'abc123'
|
|
};
|
|
|
|
assert.strictEqual(request.path, undefined);
|
|
assert.strictEqual(request.method, expected[':method']);
|
|
assert.strictEqual(request.scheme, expected[':scheme']);
|
|
assert.strictEqual(request.url, expected[':path']);
|
|
assert.strictEqual(request.authority, expected[':authority']);
|
|
|
|
const headers = request.headers;
|
|
for (const [name, value] of Object.entries(expected)) {
|
|
assert.strictEqual(headers[name], value);
|
|
}
|
|
|
|
const rawHeaders = request.rawHeaders;
|
|
for (const [name, value] of Object.entries(expected)) {
|
|
const position = rawHeaders.indexOf(name);
|
|
assert.notStrictEqual(position, -1);
|
|
assert.strictEqual(rawHeaders[position + 1], value);
|
|
}
|
|
|
|
request.url = '/one';
|
|
assert.strictEqual(request.url, '/one');
|
|
|
|
// third-party plugins for packages like express use query params to
|
|
// change the request method
|
|
request.method = 'POST';
|
|
assert.strictEqual(request.method, 'POST');
|
|
common.expectsError(
|
|
() => request.method = ' ',
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "method" argument must be of type string'
|
|
}
|
|
);
|
|
common.expectsError(
|
|
() => request.method = true,
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "method" argument must be of type string'
|
|
}
|
|
);
|
|
|
|
response.on('finish', common.mustCall(function() {
|
|
server.close();
|
|
}));
|
|
response.end();
|
|
}));
|
|
|
|
const url = `http://localhost:${port}`;
|
|
const client = h2.connect(url, common.mustCall(function() {
|
|
const headers = {
|
|
':path': '/foobar',
|
|
':method': 'GET',
|
|
':scheme': 'http',
|
|
':authority': `localhost:${port}`,
|
|
'foo-bar': 'abc123'
|
|
};
|
|
const request = client.request(headers);
|
|
request.on('end', common.mustCall(function() {
|
|
client.close();
|
|
}));
|
|
request.end();
|
|
request.resume();
|
|
}));
|
|
}));
|