mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 03:31:35 +00:00
0babd181a0
PR-URL: https://github.com/nodejs/node/pull/17406 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> This is a significant cleanup and refactoring of the cleanup/close/destroy logic for Http2Stream and Http2Session. There are significant changes here in the timing and ordering of cleanup logic, JS apis. and various related necessary edits.
49 lines
1.4 KiB
JavaScript
49 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
const NGHTTP2_INTERNAL_ERROR = h2.constants.NGHTTP2_INTERNAL_ERROR;
|
|
|
|
const server = h2.createServer();
|
|
|
|
// Do not mustCall the server side callbacks, they may or may not be called
|
|
// depending on the OS. The determination is based largely on operating
|
|
// system specific timings
|
|
server.on('stream', (stream) => {
|
|
// Do not wrap in a must call or use common.expectsError (which now uses
|
|
// must call). The error may or may not be reported depending on operating
|
|
// system specific timings.
|
|
stream.on('error', (err) => {
|
|
assert.strictEqual(err.code, 'ERR_HTTP2_STREAM_ERROR');
|
|
assert.strictEqual(err.message, 'Stream closed with error code 2');
|
|
});
|
|
stream.respond();
|
|
stream.end();
|
|
});
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = h2.connect(`http://localhost:${server.address().port}`);
|
|
|
|
const req = client.request();
|
|
req.destroy(new Error('test'));
|
|
|
|
req.on('error', common.expectsError({
|
|
type: Error,
|
|
message: 'test'
|
|
}));
|
|
|
|
req.on('close', common.mustCall((code) => {
|
|
assert.strictEqual(req.rstCode, NGHTTP2_INTERNAL_ERROR);
|
|
assert.strictEqual(code, NGHTTP2_INTERNAL_ERROR);
|
|
server.close();
|
|
client.close();
|
|
}));
|
|
|
|
req.on('response', common.mustNotCall());
|
|
req.resume();
|
|
req.on('end', common.mustCall());
|
|
}));
|