mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 21:16:53 +00:00
0babd181a0
PR-URL: https://github.com/nodejs/node/pull/17406 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> This is a significant cleanup and refactoring of the cleanup/close/destroy logic for Http2Stream and Http2Session. There are significant changes here in the timing and ordering of cleanup logic, JS apis. and various related necessary edits.
60 lines
1.4 KiB
JavaScript
60 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const http2 = require('http2');
|
|
|
|
// Check if correct errors are emitted when wrong type of data is passed
|
|
// to certain options of ClientHttp2Session request method
|
|
|
|
const optionsToTest = {
|
|
endStream: 'boolean',
|
|
getTrailers: 'function',
|
|
weight: 'number',
|
|
parent: 'number',
|
|
exclusive: 'boolean',
|
|
silent: 'boolean'
|
|
};
|
|
|
|
const types = {
|
|
boolean: true,
|
|
function: () => {},
|
|
number: 1,
|
|
object: {},
|
|
array: [],
|
|
null: null,
|
|
symbol: Symbol('test')
|
|
};
|
|
|
|
const server = http2.createServer(common.mustNotCall());
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const port = server.address().port;
|
|
const client = http2.connect(`http://localhost:${port}`);
|
|
|
|
client.on('connect', () => {
|
|
Object.keys(optionsToTest).forEach((option) => {
|
|
Object.keys(types).forEach((type) => {
|
|
if (type === optionsToTest[option])
|
|
return;
|
|
|
|
common.expectsError(
|
|
() => client.request({
|
|
':method': 'CONNECT',
|
|
':authority': `localhost:${port}`
|
|
}, {
|
|
[option]: types[type]
|
|
}), {
|
|
type: TypeError,
|
|
code: 'ERR_INVALID_OPT_VALUE',
|
|
message: `The value "${String(types[type])}" is invalid ` +
|
|
`for option "${option}"`
|
|
});
|
|
});
|
|
});
|
|
server.close();
|
|
client.close();
|
|
});
|
|
}));
|