mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 00:27:26 +00:00
df08779e0d
This commit removes `common.crashOnUnhandledRejection()` and adds `common.disableCrashOnUnhandledRejection()`. To reduce the risk of mistakes and make writing tests that involve promises simpler, always install the unhandledRejection hook in tests and provide a way to disable it for the rare cases where it's needed. PR-URL: https://github.com/nodejs/node/pull/21849 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
42 lines
1.2 KiB
JavaScript
42 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const initHooks = require('./init-hooks');
|
|
const { checkInvocations } = require('./hook-checks');
|
|
|
|
if (!common.isMainThread)
|
|
common.skip('Worker bootstrapping works differently -> different async IDs');
|
|
|
|
const p = new Promise(common.mustCall(function executor(resolve, reject) {
|
|
resolve(5);
|
|
}));
|
|
|
|
p.then(function afterresolution(val) {
|
|
assert.strictEqual(val, 5);
|
|
return val;
|
|
});
|
|
|
|
// init hooks after chained promise is created
|
|
const hooks = initHooks();
|
|
hooks._allowNoInit = true;
|
|
hooks.enable();
|
|
|
|
|
|
process.on('exit', function onexit() {
|
|
hooks.disable();
|
|
hooks.sanityCheck('PROMISE');
|
|
|
|
// Because the init event was never emitted the hooks listener doesn't
|
|
// know what the type was. Thus check for Unknown rather than PROMISE.
|
|
const as = hooks.activitiesOfTypes('PROMISE');
|
|
const unknown = hooks.activitiesOfTypes('Unknown');
|
|
assert.strictEqual(as.length, 0);
|
|
assert.strictEqual(unknown.length, 1);
|
|
|
|
const a0 = unknown[0];
|
|
assert.strictEqual(a0.type, 'Unknown');
|
|
assert.strictEqual(typeof a0.uid, 'number');
|
|
checkInvocations(a0, { before: 1, after: 1 }, 'when process exits');
|
|
});
|