mirror of
https://github.com/nodejs/node.git
synced 2025-05-10 03:12:57 +00:00
0f7c06eb2d
Use `Object.create(null)` for dictionary objects so that keys from certificate strings or the authorityInfoAccess field cannot conflict with Object.prototype properties. PR-URL: https://github.com/nodejs/node/pull/14447 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
50 lines
1.3 KiB
JavaScript
50 lines
1.3 KiB
JavaScript
/* eslint-disable no-proto */
|
|
'use strict';
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const tls = require('tls');
|
|
|
|
{
|
|
const singles = 'C=US\nST=CA\nL=SF\nO=Node.js Foundation\nOU=Node.js\n' +
|
|
'CN=ca1\nemailAddress=ry@clouds.org';
|
|
const singlesOut = tls.parseCertString(singles);
|
|
assert.deepStrictEqual(singlesOut, {
|
|
__proto__: null,
|
|
C: 'US',
|
|
ST: 'CA',
|
|
L: 'SF',
|
|
O: 'Node.js Foundation',
|
|
OU: 'Node.js',
|
|
CN: 'ca1',
|
|
emailAddress: 'ry@clouds.org'
|
|
});
|
|
}
|
|
|
|
{
|
|
const doubles = 'OU=Domain Control Validated\nOU=PositiveSSL Wildcard\n' +
|
|
'CN=*.nodejs.org';
|
|
const doublesOut = tls.parseCertString(doubles);
|
|
assert.deepStrictEqual(doublesOut, {
|
|
__proto__: null,
|
|
OU: [ 'Domain Control Validated', 'PositiveSSL Wildcard' ],
|
|
CN: '*.nodejs.org'
|
|
});
|
|
}
|
|
|
|
{
|
|
const invalid = 'fhqwhgads';
|
|
const invalidOut = tls.parseCertString(invalid);
|
|
assert.deepStrictEqual(invalidOut, { __proto__: null });
|
|
}
|
|
|
|
{
|
|
const input = '__proto__=mostly harmless\nhasOwnProperty=not a function';
|
|
const expected = Object.create(null);
|
|
expected.__proto__ = 'mostly harmless';
|
|
expected.hasOwnProperty = 'not a function';
|
|
assert.deepStrictEqual(tls.parseCertString(input), expected);
|
|
}
|