mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 15:46:27 +00:00
83a5eef6f2
Call Object.defineProperty() twice to set readonly property is unnecessary. PR-URL: https://github.com/nodejs/node/pull/13221 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
41 lines
1.2 KiB
JavaScript
41 lines
1.2 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const expected_keys = ['ares', 'http_parser', 'modules', 'node',
|
|
'uv', 'v8', 'zlib', 'nghttp2'];
|
|
|
|
if (common.hasCrypto) {
|
|
expected_keys.push('openssl');
|
|
}
|
|
|
|
if (common.hasIntl) {
|
|
expected_keys.push('icu');
|
|
expected_keys.push('cldr');
|
|
expected_keys.push('tz');
|
|
expected_keys.push('unicode');
|
|
}
|
|
|
|
expected_keys.sort();
|
|
const actual_keys = Object.keys(process.versions).sort();
|
|
|
|
assert.deepStrictEqual(actual_keys, expected_keys);
|
|
|
|
const commonTemplate = /^\d+\.\d+\.\d+(?:-.*)?$/;
|
|
|
|
assert(commonTemplate.test(process.versions.ares));
|
|
assert(commonTemplate.test(process.versions.http_parser));
|
|
assert(commonTemplate.test(process.versions.node));
|
|
assert(commonTemplate.test(process.versions.uv));
|
|
assert(commonTemplate.test(process.versions.zlib));
|
|
|
|
assert(/^\d+\.\d+\.\d+(?:\.\d+)?(?: \(candidate\))?$/
|
|
.test(process.versions.v8));
|
|
assert(/^\d+$/.test(process.versions.modules));
|
|
|
|
for (let i = 0; i < expected_keys.length; i++) {
|
|
const key = expected_keys[i];
|
|
const descriptor = Object.getOwnPropertyDescriptor(process.versions, key);
|
|
assert.strictEqual(descriptor.writable, false);
|
|
}
|