mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 13:05:07 +00:00

Problem: It's possible to run listen() on a net.Server that's already listening to a port. The result is silent failure, with the side effect of changing the connectionKey and or pipeName. Solution: throw an error if listen method called more than once. close() method should be called between listen() method calls. Refs: https://github.com/nodejs/node/pull/8294 Fixes: https://github.com/nodejs/node/issues/6190 Fixes: https://github.com/nodejs/node/issues/11685 PR-URL: https://github.com/nodejs/node/pull/13149 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
52 lines
1.2 KiB
JavaScript
52 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const net = require('net');
|
|
|
|
// First test. Check that after error event you can listen right away.
|
|
{
|
|
const dummyServer = net.Server();
|
|
const server = net.Server();
|
|
|
|
// Run some server in order to simulate EADDRINUSE error.
|
|
dummyServer.listen(common.mustCall(() => {
|
|
// Try to listen used port.
|
|
server.listen(dummyServer.address().port);
|
|
}));
|
|
|
|
server.on('error', common.mustCall((e) => {
|
|
assert.doesNotThrow(
|
|
() => server.listen(common.mustCall(() => {
|
|
dummyServer.close();
|
|
server.close();
|
|
}))
|
|
);
|
|
}));
|
|
}
|
|
|
|
// Second test. Check that second listen call throws an error.
|
|
{
|
|
const server = net.Server();
|
|
|
|
server.listen(common.mustCall(() => server.close()));
|
|
|
|
common.expectsError(() => server.listen(), {
|
|
code: 'ERR_SERVER_ALREADY_LISTEN',
|
|
type: Error
|
|
});
|
|
}
|
|
|
|
// Third test.
|
|
// Check that after the close call you can run listen method just fine.
|
|
{
|
|
const server = net.Server();
|
|
|
|
server.listen(common.mustCall(() => {
|
|
server.close();
|
|
assert.doesNotThrow(
|
|
() => server.listen(common.mustCall(() => server.close()))
|
|
);
|
|
}));
|
|
}
|