mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 18:02:21 +00:00
1b719fe3d7
When building --without-ssl and running the tests some of the http2 test
fail with the following error message:
internal/util.js:82
throw new errors.Error('ERR_NO_CRYPTO');
^
Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto
support
at Object.assertCrypto (internal/util.js:82:11)
at internal/http2/core.js:5:26
at NativeModule.compile (bootstrap_node.js:586:7)
at NativeModule.require (bootstrap_node.js:531:18)
at http2.js:17:5
at NativeModule.compile (bootstrap_node.js:586:7)
at Function.NativeModule.require (bootstrap_node.js:531:18)
at Function.Module._load (module.js:449:25)
at Module.require (module.js:517:17)
at require (internal/module.js:11:18)
This commit adds hasCrypto checks and skips the tests if there is no
crypto support.
PR-URL: https://github.com/nodejs/node/pull/14657
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
62 lines
1.4 KiB
JavaScript
62 lines
1.4 KiB
JavaScript
// Flags: --expose-http2
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const http2 = require('http2');
|
|
|
|
const server = http2.createServer();
|
|
|
|
// Each of these headers must appear only once
|
|
const singles = [
|
|
'content-type',
|
|
'user-agent',
|
|
'referer',
|
|
'authorization',
|
|
'proxy-authorization',
|
|
'if-modified-since',
|
|
'if-unmodified-since',
|
|
'from',
|
|
'location',
|
|
'max-forwards'
|
|
];
|
|
|
|
server.on('stream', common.mustNotCall());
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
|
|
let remaining = singles.length * 2;
|
|
function maybeClose() {
|
|
if (--remaining === 0) {
|
|
server.close();
|
|
client.destroy();
|
|
}
|
|
}
|
|
|
|
singles.forEach((i) => {
|
|
const req = client.request({
|
|
[i]: 'abc',
|
|
[i.toUpperCase()]: 'xyz'
|
|
});
|
|
req.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_HEADER_SINGLE_VALUE',
|
|
type: Error,
|
|
message: `Header field "${i}" must have only a single value`
|
|
}));
|
|
req.on('error', common.mustCall(maybeClose));
|
|
|
|
const req2 = client.request({
|
|
[i]: ['abc', 'xyz']
|
|
});
|
|
req2.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_HEADER_SINGLE_VALUE',
|
|
type: Error,
|
|
message: `Header field "${i}" must have only a single value`
|
|
}));
|
|
req2.on('error', common.mustCall(maybeClose));
|
|
});
|
|
|
|
}));
|