mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 19:38:23 +00:00
1b719fe3d7
When building --without-ssl and running the tests some of the http2 test
fail with the following error message:
internal/util.js:82
throw new errors.Error('ERR_NO_CRYPTO');
^
Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto
support
at Object.assertCrypto (internal/util.js:82:11)
at internal/http2/core.js:5:26
at NativeModule.compile (bootstrap_node.js:586:7)
at NativeModule.require (bootstrap_node.js:531:18)
at http2.js:17:5
at NativeModule.compile (bootstrap_node.js:586:7)
at Function.NativeModule.require (bootstrap_node.js:531:18)
at Function.Module._load (module.js:449:25)
at Module.require (module.js:517:17)
at require (internal/module.js:11:18)
This commit adds hasCrypto checks and skips the tests if there is no
crypto support.
PR-URL: https://github.com/nodejs/node/pull/14657
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
70 lines
1.7 KiB
JavaScript
70 lines
1.7 KiB
JavaScript
// Flags: --expose-http2
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
|
|
const {
|
|
HTTP2_HEADER_METHOD,
|
|
HTTP2_HEADER_STATUS,
|
|
HTTP2_HEADER_PATH,
|
|
HTTP2_METHOD_POST
|
|
} = h2.constants;
|
|
|
|
// Only allow one stream to be open at a time
|
|
const server = h2.createServer({ settings: { maxConcurrentStreams: 1 } });
|
|
|
|
// The stream handler must be called only once
|
|
server.on('stream', common.mustCall((stream) => {
|
|
stream.respond({ [HTTP2_HEADER_STATUS]: 200 });
|
|
stream.end('hello world');
|
|
}));
|
|
server.listen(0);
|
|
|
|
server.on('listening', common.mustCall(() => {
|
|
|
|
const client = h2.connect(`http://localhost:${server.address().port}`);
|
|
|
|
let reqs = 2;
|
|
function onEnd() {
|
|
if (--reqs === 0) {
|
|
server.close();
|
|
client.destroy();
|
|
}
|
|
}
|
|
|
|
client.on('remoteSettings', common.mustCall((settings) => {
|
|
assert.strictEqual(settings.maxConcurrentStreams, 1);
|
|
}));
|
|
|
|
// This one should go through with no problems
|
|
const req1 = client.request({
|
|
[HTTP2_HEADER_PATH]: '/',
|
|
[HTTP2_HEADER_METHOD]: HTTP2_METHOD_POST
|
|
});
|
|
req1.on('aborted', common.mustNotCall());
|
|
req1.on('response', common.mustCall());
|
|
req1.resume();
|
|
req1.on('end', onEnd);
|
|
req1.end();
|
|
|
|
// This one should be aborted
|
|
const req2 = client.request({
|
|
[HTTP2_HEADER_PATH]: '/',
|
|
[HTTP2_HEADER_METHOD]: HTTP2_METHOD_POST
|
|
});
|
|
req2.on('aborted', common.mustCall());
|
|
req2.on('response', common.mustNotCall());
|
|
req2.resume();
|
|
req2.on('end', onEnd);
|
|
req2.on('error', common.mustCall(common.expectsError({
|
|
code: 'ERR_HTTP2_STREAM_ERROR',
|
|
type: Error,
|
|
message: 'Stream closed with error code 7'
|
|
})));
|
|
|
|
}));
|