mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 13:05:07 +00:00
1b719fe3d7
When building --without-ssl and running the tests some of the http2 test
fail with the following error message:
internal/util.js:82
throw new errors.Error('ERR_NO_CRYPTO');
^
Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto
support
at Object.assertCrypto (internal/util.js:82:11)
at internal/http2/core.js:5:26
at NativeModule.compile (bootstrap_node.js:586:7)
at NativeModule.require (bootstrap_node.js:531:18)
at http2.js:17:5
at NativeModule.compile (bootstrap_node.js:586:7)
at Function.NativeModule.require (bootstrap_node.js:531:18)
at Function.Module._load (module.js:449:25)
at Module.require (module.js:517:17)
at require (internal/module.js:11:18)
This commit adds hasCrypto checks and skips the tests if there is no
crypto support.
PR-URL: https://github.com/nodejs/node/pull/14657
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
92 lines
2.5 KiB
JavaScript
92 lines
2.5 KiB
JavaScript
// Flags: --expose-http2
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
|
|
// Push a request & response
|
|
|
|
const pushExpect = 'This is a server-initiated response';
|
|
const servExpect = 'This is a client-initiated response';
|
|
|
|
const server = h2.createServer((request, response) => {
|
|
assert.strictEqual(response.stream.id % 2, 1);
|
|
response.write(servExpect);
|
|
|
|
response.createPushResponse({
|
|
':path': '/pushed',
|
|
':method': 'GET'
|
|
}, common.mustCall((error, push) => {
|
|
assert.ifError(error);
|
|
assert.strictEqual(push.stream.id % 2, 0);
|
|
push.end(pushExpect);
|
|
response.end();
|
|
|
|
// wait for a tick, so the stream is actually closed
|
|
setImmediate(function() {
|
|
response.createPushResponse({
|
|
':path': '/pushed',
|
|
':method': 'GET'
|
|
}, common.mustCall((error) => {
|
|
assert.strictEqual(error.code, 'ERR_HTTP2_STREAM_CLOSED');
|
|
}));
|
|
});
|
|
}));
|
|
});
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const port = server.address().port;
|
|
|
|
const client = h2.connect(`http://localhost:${port}`, common.mustCall(() => {
|
|
const headers = {
|
|
':path': '/',
|
|
':method': 'GET',
|
|
};
|
|
|
|
let remaining = 2;
|
|
function maybeClose() {
|
|
if (--remaining === 0) {
|
|
client.destroy();
|
|
server.close();
|
|
}
|
|
}
|
|
|
|
const req = client.request(headers);
|
|
|
|
client.on('stream', common.mustCall((pushStream, headers) => {
|
|
assert.strictEqual(headers[':path'], '/pushed');
|
|
assert.strictEqual(headers[':method'], 'GET');
|
|
assert.strictEqual(headers[':scheme'], 'http');
|
|
assert.strictEqual(headers[':authority'], `localhost:${port}`);
|
|
|
|
let actual = '';
|
|
pushStream.on('push', common.mustCall((headers) => {
|
|
assert.strictEqual(headers[':status'], 200);
|
|
assert(headers['date']);
|
|
}));
|
|
pushStream.setEncoding('utf8');
|
|
pushStream.on('data', (chunk) => actual += chunk);
|
|
pushStream.on('end', common.mustCall(() => {
|
|
assert.strictEqual(actual, pushExpect);
|
|
maybeClose();
|
|
}));
|
|
}));
|
|
|
|
req.on('response', common.mustCall((headers) => {
|
|
assert.strictEqual(headers[':status'], 200);
|
|
assert(headers['date']);
|
|
}));
|
|
|
|
let actual = '';
|
|
req.setEncoding('utf8');
|
|
req.on('data', (chunk) => actual += chunk);
|
|
req.on('end', common.mustCall(() => {
|
|
assert.strictEqual(actual, servExpect);
|
|
maybeClose();
|
|
}));
|
|
}));
|
|
}));
|