mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 13:05:07 +00:00
1b719fe3d7
When building --without-ssl and running the tests some of the http2 test
fail with the following error message:
internal/util.js:82
throw new errors.Error('ERR_NO_CRYPTO');
^
Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto
support
at Object.assertCrypto (internal/util.js:82:11)
at internal/http2/core.js:5:26
at NativeModule.compile (bootstrap_node.js:586:7)
at NativeModule.require (bootstrap_node.js:531:18)
at http2.js:17:5
at NativeModule.compile (bootstrap_node.js:586:7)
at Function.NativeModule.require (bootstrap_node.js:531:18)
at Function.Module._load (module.js:449:25)
at Module.require (module.js:517:17)
at require (internal/module.js:11:18)
This commit adds hasCrypto checks and skips the tests if there is no
crypto support.
PR-URL: https://github.com/nodejs/node/pull/14657
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
57 lines
1.5 KiB
JavaScript
57 lines
1.5 KiB
JavaScript
// Flags: --expose-http2
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
|
|
const server = h2.createServer();
|
|
server.listen(0);
|
|
|
|
server.on('listening', common.mustCall(function() {
|
|
const port = this.address().port;
|
|
|
|
const destroyCallbacks = [
|
|
(client) => client.destroy(),
|
|
(client) => client.socket.destroy()
|
|
];
|
|
|
|
let remaining = destroyCallbacks.length;
|
|
|
|
destroyCallbacks.forEach((destroyCallback) => {
|
|
const client = h2.connect(`http://localhost:${port}`);
|
|
client.on('connect', common.mustCall(() => {
|
|
const socket = client.socket;
|
|
|
|
assert(client.socket, 'client session has associated socket');
|
|
assert(!client.destroyed,
|
|
'client has not been destroyed before destroy is called');
|
|
assert(!socket.destroyed,
|
|
'socket has not been destroyed before destroy is called');
|
|
|
|
// Ensure that 'close' event is emitted
|
|
client.on('close', common.mustCall());
|
|
|
|
destroyCallback(client);
|
|
|
|
assert(!client.socket, 'client.socket undefined after destroy is called');
|
|
|
|
// Must must be closed
|
|
client.on('close', common.mustCall(() => {
|
|
assert(client.destroyed);
|
|
}));
|
|
|
|
// socket will close on process.nextTick
|
|
socket.on('close', common.mustCall(() => {
|
|
assert(socket.destroyed);
|
|
}));
|
|
|
|
if (--remaining === 0) {
|
|
server.close();
|
|
}
|
|
}));
|
|
});
|
|
}));
|