mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 13:05:07 +00:00
7535a94c8a
Adds a new `../common/fixtures' module to begin normalizing `test/fixtures` use. Our test code is a bit inconsistent with regards to use of the fixtures directory. Some code uses `path.join()`, some code uses string concats, some other code uses template strings, etc. In mnay cases, significant duplication of code is seen when accessing fixture files, etc. This updates many (but by no means all) of the tests in the test suite to use the new consistent API. There are still many more to update, which would make an excelent Code-n-Learn exercise. PR-URL: https://github.com/nodejs/node/pull/14332 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
23 lines
616 B
JavaScript
23 lines
616 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const filepath = fixtures.path('x.txt');
|
|
const fd = fs.openSync(filepath, 'r');
|
|
const expected = 'xyz\n';
|
|
|
|
// Error must be thrown with string
|
|
assert.throws(() => {
|
|
fs.read(fd,
|
|
expected.length,
|
|
0,
|
|
'utf-8',
|
|
common.mustNotCall());
|
|
}, /^TypeError: Second argument needs to be a buffer$/);
|
|
|
|
assert.throws(() => {
|
|
fs.readSync(fd, expected.length, 0, 'utf-8');
|
|
}, /^TypeError: Second argument needs to be a buffer$/);
|