mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 15:46:27 +00:00
e912c67d24
Covert lib/dgram.js over to using lib/internal/errors.js for generating Errors. See [using-internal-errors.md](https://github.com/nodejs/node/blob/master/doc/guides/using-internal-errors.md) for more details. I have not addressed the cases that use errnoException() and exceptionWithHostPort() helper methods as changing these would require fixing the tests across all of the different files that use them. In addition, these helpers already add a `code` to the Error and we'll have to discuss how that interacts with the `code` used by lib/internal/errors.js. I believe we should convert all users of errnoException and exceptionWithHostPort in a PR dedicated to that conversion. PR-URL: https://github.com/nodejs/node/pull/12926 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ruben Bridgewater <ruben.bridgewater@fintura.de>
56 lines
1.6 KiB
JavaScript
56 lines
1.6 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const dgram = require('dgram');
|
|
const dns = require('dns');
|
|
|
|
// Monkey patch dns.lookup() so that it always fails.
|
|
dns.lookup = function(address, family, callback) {
|
|
process.nextTick(() => { callback(new Error('fake DNS')); });
|
|
};
|
|
|
|
const socket = dgram.createSocket('udp4');
|
|
let dnsFailures = 0;
|
|
let sendFailures = 0;
|
|
|
|
process.on('exit', () => {
|
|
assert.strictEqual(dnsFailures, 3);
|
|
assert.strictEqual(sendFailures, 3);
|
|
});
|
|
|
|
socket.on('error', (err) => {
|
|
if (/^Error: fake DNS$/.test(err)) {
|
|
// The DNS lookup should fail since it is monkey patched. At that point in
|
|
// time, the send queue should be populated with the send() operation. There
|
|
// should also be two listeners - this function and the dgram internal one
|
|
// time error handler.
|
|
dnsFailures++;
|
|
assert(Array.isArray(socket._queue));
|
|
assert.strictEqual(socket._queue.length, 1);
|
|
assert.strictEqual(socket.listenerCount('error'), 2);
|
|
return;
|
|
}
|
|
|
|
if (err.code === 'ERR_SOCKET_CANNOT_SEND') {
|
|
// On error, the queue should be destroyed and this function should be
|
|
// the only listener.
|
|
sendFailures++;
|
|
assert.strictEqual(socket._queue, undefined);
|
|
assert.strictEqual(socket.listenerCount('error'), 1);
|
|
return;
|
|
}
|
|
|
|
assert.fail(`Unexpected error: ${err}`);
|
|
});
|
|
|
|
// Initiate a few send() operations, which will fail.
|
|
socket.send('foobar', common.PORT, 'localhost');
|
|
|
|
process.nextTick(() => {
|
|
socket.send('foobar', common.PORT, 'localhost');
|
|
});
|
|
|
|
setImmediate(() => {
|
|
socket.send('foobar', common.PORT, 'localhost');
|
|
});
|