mirror of
https://github.com/nodejs/node.git
synced 2025-05-08 02:52:29 +00:00
06ecf4dec7
Even though this is not fully Web IDL spec-compliant, it is arguably the best we can do. Following the spec would mean non-trivial performance deterioration (10% when parsing a medium-length URL), while the current getter behavior is not adopted by any implementer, and it causes some spec ambiguity when the getter is called with !(this instanceof URL). This commit adopts Chrome's behavior, and is consistent with ECMAScript-defined classes while providing reasonable behaviors for corner cases as well. Until the Web IDL spec is changed one way or another, this is the way to go. PR-URL: https://github.com/nodejs/node/pull/10906 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
145 lines
5.7 KiB
JavaScript
145 lines
5.7 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
|
|
require('../common');
|
|
|
|
const URL = require('url').URL;
|
|
const assert = require('assert');
|
|
const urlToOptions = require('internal/url').urlToOptions;
|
|
|
|
const url = new URL('http://user:pass@foo.bar.com:21/aaa/zzz?l=24#test');
|
|
const oldParams = url.searchParams; // for test of [SameObject]
|
|
|
|
// To retrieve enumerable but not necessarily own properties,
|
|
// we need to use the for-in loop.
|
|
const props = [];
|
|
for (const prop in url) {
|
|
props.push(prop);
|
|
}
|
|
|
|
// See: https://url.spec.whatwg.org/#api
|
|
// https://heycam.github.io/webidl/#es-attributes
|
|
// https://heycam.github.io/webidl/#es-stringifier
|
|
const expected = ['toString',
|
|
'href', 'origin', 'protocol',
|
|
'username', 'password', 'host', 'hostname', 'port',
|
|
'pathname', 'search', 'searchParams', 'hash'];
|
|
|
|
assert.deepStrictEqual(props, expected);
|
|
|
|
// href is writable (not readonly) and is stringifier
|
|
assert.strictEqual(url.toString(), url.href);
|
|
url.href = 'http://user:pass@foo.bar.com:21/aaa/zzz?l=25#test';
|
|
assert.strictEqual(url.href,
|
|
'http://user:pass@foo.bar.com:21/aaa/zzz?l=25#test');
|
|
assert.strictEqual(url.toString(), url.href);
|
|
// Return true because it's configurable, but because the properties
|
|
// are defined on the prototype per the spec, the deletion has no effect
|
|
assert.strictEqual((delete url.href), true);
|
|
assert.strictEqual(url.href,
|
|
'http://user:pass@foo.bar.com:21/aaa/zzz?l=25#test');
|
|
assert.strictEqual(url.searchParams, oldParams); // [SameObject]
|
|
|
|
// searchParams is readonly. Under strict mode setting a
|
|
// non-writable property should throw.
|
|
// Note: this error message is subject to change in V8 updates
|
|
assert.throws(() => url.origin = 'http://foo.bar.com:22',
|
|
new RegExp('TypeError: Cannot set property origin of' +
|
|
' \\[object URL\\] which has only a getter'));
|
|
assert.strictEqual(url.origin, 'http://foo.bar.com:21');
|
|
assert.strictEqual(url.toString(),
|
|
'http://user:pass@foo.bar.com:21/aaa/zzz?l=25#test');
|
|
assert.strictEqual((delete url.origin), true);
|
|
assert.strictEqual(url.origin, 'http://foo.bar.com:21');
|
|
|
|
// The following properties should be writable (not readonly)
|
|
url.protocol = 'https:';
|
|
assert.strictEqual(url.protocol, 'https:');
|
|
assert.strictEqual(url.toString(),
|
|
'https://user:pass@foo.bar.com:21/aaa/zzz?l=25#test');
|
|
assert.strictEqual((delete url.protocol), true);
|
|
assert.strictEqual(url.protocol, 'https:');
|
|
|
|
url.username = 'user2';
|
|
assert.strictEqual(url.username, 'user2');
|
|
assert.strictEqual(url.toString(),
|
|
'https://user2:pass@foo.bar.com:21/aaa/zzz?l=25#test');
|
|
assert.strictEqual((delete url.username), true);
|
|
assert.strictEqual(url.username, 'user2');
|
|
|
|
url.password = 'pass2';
|
|
assert.strictEqual(url.password, 'pass2');
|
|
assert.strictEqual(url.toString(),
|
|
'https://user2:pass2@foo.bar.com:21/aaa/zzz?l=25#test');
|
|
assert.strictEqual((delete url.password), true);
|
|
assert.strictEqual(url.password, 'pass2');
|
|
|
|
url.host = 'foo.bar.net:22';
|
|
assert.strictEqual(url.host, 'foo.bar.net:22');
|
|
assert.strictEqual(url.toString(),
|
|
'https://user2:pass2@foo.bar.net:22/aaa/zzz?l=25#test');
|
|
assert.strictEqual((delete url.host), true);
|
|
assert.strictEqual(url.host, 'foo.bar.net:22');
|
|
|
|
url.hostname = 'foo.bar.org';
|
|
assert.strictEqual(url.hostname, 'foo.bar.org');
|
|
assert.strictEqual(url.toString(),
|
|
'https://user2:pass2@foo.bar.org:22/aaa/zzz?l=25#test');
|
|
assert.strictEqual((delete url.hostname), true);
|
|
assert.strictEqual(url.hostname, 'foo.bar.org');
|
|
|
|
url.port = '23';
|
|
assert.strictEqual(url.port, '23');
|
|
assert.strictEqual(url.toString(),
|
|
'https://user2:pass2@foo.bar.org:23/aaa/zzz?l=25#test');
|
|
assert.strictEqual((delete url.port), true);
|
|
assert.strictEqual(url.port, '23');
|
|
|
|
url.pathname = '/aaa/bbb';
|
|
assert.strictEqual(url.pathname, '/aaa/bbb');
|
|
assert.strictEqual(url.toString(),
|
|
'https://user2:pass2@foo.bar.org:23/aaa/bbb?l=25#test');
|
|
assert.strictEqual((delete url.pathname), true);
|
|
assert.strictEqual(url.pathname, '/aaa/bbb');
|
|
|
|
url.search = '?k=99';
|
|
assert.strictEqual(url.search, '?k=99');
|
|
assert.strictEqual(url.toString(),
|
|
'https://user2:pass2@foo.bar.org:23/aaa/bbb?k=99#test');
|
|
assert.strictEqual((delete url.search), true);
|
|
assert.strictEqual(url.search, '?k=99');
|
|
|
|
url.hash = '#abcd';
|
|
assert.strictEqual(url.hash, '#abcd');
|
|
assert.strictEqual(url.toString(),
|
|
'https://user2:pass2@foo.bar.org:23/aaa/bbb?k=99#abcd');
|
|
assert.strictEqual((delete url.hash), true);
|
|
assert.strictEqual(url.hash, '#abcd');
|
|
|
|
// searchParams is readonly. Under strict mode setting a
|
|
// non-writable property should throw.
|
|
// Note: this error message is subject to change in V8 updates
|
|
assert.throws(() => url.searchParams = '?k=88',
|
|
new RegExp('TypeError: Cannot set property searchParams of' +
|
|
' \\[object URL\\] which has only a getter'));
|
|
assert.strictEqual(url.searchParams, oldParams);
|
|
assert.strictEqual(url.toString(),
|
|
'https://user2:pass2@foo.bar.org:23/aaa/bbb?k=99#abcd');
|
|
assert.strictEqual((delete url.searchParams), true);
|
|
assert.strictEqual(url.searchParams, oldParams);
|
|
|
|
// Test urlToOptions
|
|
{
|
|
const opts =
|
|
urlToOptions(new URL('http://user:pass@foo.bar.com:21/aaa/zzz?l=24#test'));
|
|
assert.strictEqual(opts instanceof URL, false);
|
|
assert.strictEqual(opts.protocol, 'http:');
|
|
assert.strictEqual(opts.auth, 'user:pass');
|
|
assert.strictEqual(opts.hostname, 'foo.bar.com');
|
|
assert.strictEqual(opts.port, 21);
|
|
assert.strictEqual(opts.path, '/aaa/zzz?l=24');
|
|
assert.strictEqual(opts.pathname, '/aaa/zzz');
|
|
assert.strictEqual(opts.search, '?l=24');
|
|
assert.strictEqual(opts.hash, '#test');
|
|
}
|