mirror of
https://github.com/nodejs/node.git
synced 2025-05-14 10:27:25 +00:00
062beb08df
* id values of -1 are allowed. They indicate that the id was never
correctly assigned to the async resource. These will appear in any
call graph, and will only be apparent to those using the async_hooks
module, then reported in an issue.
* ids < -1 are still not allowed and will cause the application to
exit the process; because there is no scenario where this should ever
happen.
* Add asyncId range checks to emitAfterScript().
* Fix emitBeforeScript() range checks which should have been || not &&.
* Replace errors with entries in internal/errors.
* Fix async_hooks tests that check for exceptions to match new
internal/errors entries.
NOTE: emit{Before,After,Destroy}() must continue to exit the process
because in the case of an exception during hook execution the state of
the application is unknowable. For example, an exception could cause a
memory leak:
const id_map = new Map();
before(id) {
id_map.set(id, /* data object or similar */);
},
after(id) {
throw new Error('id never dies!');
id_map.delete(id);
}
Allowing a recoverable exception may also cause an abort because of a
stack check in Environment::AsyncHooks::pop_ids() that verifies the
async id and pop'd ids match. This case would be more difficult to debug
than if fatalError() (lib/async_hooks.js) was called immediately.
try {
async_hooks.emitBefore(null, NaN);
} catch (e) { }
// do something
async_hooks.emitAfter(5);
It also allows an edge case where emitBefore() could be called twice and
not have the pop_ids() CHECK fail:
try {
async_hooks.emitBefore(5, NaN);
} catch (e) { }
async_hooks.emitBefore(5);
// do something
async_hooks.emitAfter(5);
There is the option of allowing mismatches in the stack and ignoring the
check if no async hooks are enabled, but I don't believe going this far
is necessary.
PR-URL: https://github.com/nodejs/node/pull/14722
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
275 lines
8.9 KiB
JavaScript
275 lines
8.9 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
const errors = require('internal/errors');
|
|
const assert = require('assert');
|
|
|
|
const errMessages = {
|
|
objectString: /^'object' === 'string'$/,
|
|
booleanString: /^'boolean' === 'string'$/,
|
|
numberString: /^'number' === 'string'$/,
|
|
invalidKey: /^An invalid error message key was used: TEST_FOO_KEY\.$/,
|
|
};
|
|
|
|
errors.E('TEST_ERROR_1', 'Error for testing purposes: %s');
|
|
errors.E('TEST_ERROR_2', (a, b) => `${a} ${b}`);
|
|
|
|
const err1 = new errors.Error('TEST_ERROR_1', 'test');
|
|
const err2 = new errors.TypeError('TEST_ERROR_1', 'test');
|
|
const err3 = new errors.RangeError('TEST_ERROR_1', 'test');
|
|
const err4 = new errors.Error('TEST_ERROR_2', 'abc', 'xyz');
|
|
const err5 = new errors.Error('TEST_ERROR_1');
|
|
|
|
assert(err1 instanceof Error);
|
|
assert.strictEqual(err1.name, 'Error [TEST_ERROR_1]');
|
|
assert.strictEqual(err1.message, 'Error for testing purposes: test');
|
|
assert.strictEqual(err1.code, 'TEST_ERROR_1');
|
|
|
|
assert(err2 instanceof TypeError);
|
|
assert.strictEqual(err2.name, 'TypeError [TEST_ERROR_1]');
|
|
assert.strictEqual(err2.message, 'Error for testing purposes: test');
|
|
assert.strictEqual(err2.code, 'TEST_ERROR_1');
|
|
|
|
assert(err3 instanceof RangeError);
|
|
assert.strictEqual(err3.name, 'RangeError [TEST_ERROR_1]');
|
|
assert.strictEqual(err3.message, 'Error for testing purposes: test');
|
|
assert.strictEqual(err3.code, 'TEST_ERROR_1');
|
|
|
|
assert(err4 instanceof Error);
|
|
assert.strictEqual(err4.name, 'Error [TEST_ERROR_2]');
|
|
assert.strictEqual(err4.message, 'abc xyz');
|
|
assert.strictEqual(err4.code, 'TEST_ERROR_2');
|
|
|
|
assert(err5 instanceof Error);
|
|
assert.strictEqual(err5.name, 'Error [TEST_ERROR_1]');
|
|
assert.strictEqual(err5.message, 'Error for testing purposes: %s');
|
|
assert.strictEqual(err5.code, 'TEST_ERROR_1');
|
|
|
|
assert.throws(
|
|
() => new errors.Error('TEST_FOO_KEY'),
|
|
common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: errMessages.invalidKey
|
|
}));
|
|
// Calling it twice yields same result (using the key does not create it)
|
|
assert.throws(
|
|
() => new errors.Error('TEST_FOO_KEY'),
|
|
common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: errMessages.invalidKey
|
|
}));
|
|
assert.throws(
|
|
() => new errors.Error(1),
|
|
common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: errMessages.numberString
|
|
}));
|
|
assert.throws(
|
|
() => new errors.Error({}),
|
|
common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: errMessages.objectString
|
|
}));
|
|
assert.throws(
|
|
() => new errors.Error([]),
|
|
common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: errMessages.objectString
|
|
}));
|
|
assert.throws(
|
|
() => new errors.Error(true),
|
|
common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: errMessages.booleanString
|
|
}));
|
|
assert.throws(
|
|
() => new errors.TypeError(1),
|
|
common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: errMessages.numberString
|
|
}));
|
|
assert.throws(
|
|
() => new errors.TypeError({}),
|
|
common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: errMessages.objectString
|
|
}));
|
|
assert.throws(
|
|
() => new errors.TypeError([]),
|
|
common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: errMessages.objectString
|
|
}));
|
|
assert.throws(
|
|
() => new errors.TypeError(true),
|
|
common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: errMessages.booleanString
|
|
}));
|
|
assert.throws(
|
|
() => new errors.RangeError(1),
|
|
common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: errMessages.numberString
|
|
}));
|
|
assert.throws(
|
|
() => new errors.RangeError({}),
|
|
common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: errMessages.objectString
|
|
}));
|
|
assert.throws(
|
|
() => new errors.RangeError([]),
|
|
common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: errMessages.objectString
|
|
}));
|
|
assert.throws(
|
|
() => new errors.RangeError(true),
|
|
common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: errMessages.booleanString
|
|
}));
|
|
|
|
|
|
// Tests for common.expectsError
|
|
assert.doesNotThrow(() => {
|
|
assert.throws(() => {
|
|
throw new errors.TypeError('TEST_ERROR_1', 'a');
|
|
}, common.expectsError({ code: 'TEST_ERROR_1' }));
|
|
});
|
|
|
|
assert.doesNotThrow(() => {
|
|
assert.throws(() => {
|
|
throw new errors.TypeError('TEST_ERROR_1', 'a');
|
|
}, common.expectsError({ code: 'TEST_ERROR_1',
|
|
type: TypeError,
|
|
message: /^Error for testing/ }));
|
|
});
|
|
|
|
assert.doesNotThrow(() => {
|
|
assert.throws(() => {
|
|
throw new errors.TypeError('TEST_ERROR_1', 'a');
|
|
}, common.expectsError({ code: 'TEST_ERROR_1', type: TypeError }));
|
|
});
|
|
|
|
assert.doesNotThrow(() => {
|
|
assert.throws(() => {
|
|
throw new errors.TypeError('TEST_ERROR_1', 'a');
|
|
}, common.expectsError({ code: 'TEST_ERROR_1', type: Error }));
|
|
});
|
|
|
|
assert.throws(() => {
|
|
assert.throws(() => {
|
|
throw new errors.TypeError('TEST_ERROR_1', 'a');
|
|
}, common.expectsError({ code: 'TEST_ERROR_1', type: RangeError }));
|
|
}, common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: /^.+ is not instance of \S/
|
|
}));
|
|
|
|
assert.throws(() => {
|
|
assert.throws(() => {
|
|
throw new errors.TypeError('TEST_ERROR_1', 'a');
|
|
}, common.expectsError({ code: 'TEST_ERROR_1',
|
|
type: TypeError,
|
|
message: /^Error for testing 2/ }));
|
|
}, common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: /.+ does not match \S/
|
|
}));
|
|
|
|
// // Test ERR_INVALID_ARG_TYPE
|
|
assert.strictEqual(errors.message('ERR_INVALID_ARG_TYPE', ['a', 'b']),
|
|
'The "a" argument must be of type b');
|
|
assert.strictEqual(errors.message('ERR_INVALID_ARG_TYPE', ['a', ['b']]),
|
|
'The "a" argument must be of type b');
|
|
assert.strictEqual(errors.message('ERR_INVALID_ARG_TYPE', ['a', ['b', 'c']]),
|
|
'The "a" argument must be one of type b or c');
|
|
assert.strictEqual(errors.message('ERR_INVALID_ARG_TYPE',
|
|
['a', ['b', 'c', 'd']]),
|
|
'The "a" argument must be one of type b, c, or d');
|
|
assert.strictEqual(errors.message('ERR_INVALID_ARG_TYPE', ['a', 'b', 'c']),
|
|
'The "a" argument must be of type b. Received type string');
|
|
assert.strictEqual(errors.message('ERR_INVALID_ARG_TYPE',
|
|
['a', 'b', undefined]),
|
|
'The "a" argument must be of type b. Received type ' +
|
|
'undefined');
|
|
assert.strictEqual(errors.message('ERR_INVALID_ARG_TYPE',
|
|
['a', 'b', null]),
|
|
'The "a" argument must be of type b. Received type null');
|
|
|
|
// Test ERR_INVALID_URL_SCHEME
|
|
assert.strictEqual(errors.message('ERR_INVALID_URL_SCHEME', ['file']),
|
|
'The URL must be of scheme file');
|
|
assert.strictEqual(errors.message('ERR_INVALID_URL_SCHEME', [['file']]),
|
|
'The URL must be of scheme file');
|
|
assert.strictEqual(errors.message('ERR_INVALID_URL_SCHEME', [['http', 'ftp']]),
|
|
'The URL must be one of scheme http or ftp');
|
|
assert.strictEqual(errors.message('ERR_INVALID_URL_SCHEME', [['a', 'b', 'c']]),
|
|
'The URL must be one of scheme a, b, or c');
|
|
assert.throws(
|
|
() => errors.message('ERR_INVALID_URL_SCHEME', [[]]),
|
|
common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: /^At least one expected value needs to be specified$/
|
|
}));
|
|
|
|
// Test ERR_MISSING_ARGS
|
|
assert.strictEqual(errors.message('ERR_MISSING_ARGS', ['name']),
|
|
'The "name" argument must be specified');
|
|
assert.strictEqual(errors.message('ERR_MISSING_ARGS', ['name', 'value']),
|
|
'The "name" and "value" arguments must be specified');
|
|
assert.strictEqual(errors.message('ERR_MISSING_ARGS', ['a', 'b', 'c']),
|
|
'The "a", "b", and "c" arguments must be specified');
|
|
assert.throws(
|
|
() => errors.message('ERR_MISSING_ARGS'),
|
|
common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: /^At least one arg needs to be specified$/
|
|
}));
|
|
|
|
|
|
// Test ERR_TLS_CERT_ALTNAME_INVALID
|
|
assert.strictEqual(
|
|
errors.message('ERR_TLS_CERT_ALTNAME_INVALID', ['altname']),
|
|
'Hostname/IP does not match certificate\'s altnames: altname');
|
|
|
|
assert.strictEqual(
|
|
errors.message('ERR_INVALID_PROTOCOL', ['bad protocol', 'http']),
|
|
'Protocol "bad protocol" not supported. Expected "http"'
|
|
);
|
|
|
|
assert.strictEqual(
|
|
errors.message('ERR_HTTP_HEADERS_SENT', ['render']),
|
|
'Cannot render headers after they are sent to the client'
|
|
);
|
|
|
|
assert.strictEqual(
|
|
errors.message('ERR_INVALID_DOMAIN_NAME'),
|
|
'Unable to determine the domain name'
|
|
);
|
|
|
|
assert.strictEqual(
|
|
errors.message('ERR_INVALID_HTTP_TOKEN', ['Method', 'foo']),
|
|
'Method must be a valid HTTP token ["foo"]'
|
|
);
|
|
|
|
assert.strictEqual(
|
|
errors.message('ERR_UNESCAPED_CHARACTERS', ['Request path']),
|
|
'Request path contains unescaped characters'
|
|
);
|
|
|
|
|
|
// Test error messages for async_hooks
|
|
assert.strictEqual(
|
|
errors.message('ERR_ASYNC_CALLBACK', ['init']),
|
|
'init must be a function');
|
|
assert.strictEqual(
|
|
errors.message('ERR_ASYNC_TYPE', [{}]),
|
|
'Invalid name for async "type": [object Object]');
|
|
assert.strictEqual(
|
|
errors.message('ERR_INVALID_ASYNC_ID', ['asyncId', undefined]),
|
|
'Invalid asyncId value: undefined');
|