mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 07:19:19 +00:00
04b4d15b39
Many of the tests use variables to track when callback functions are invoked or events are emitted. These variables are then asserted on process exit. This commit replaces this pattern in straightforward cases with common.mustCall(). This makes the tests easier to reason about, leads to a net reduction in lines of code, and uncovered a few bugs in tests. This commit also replaces some callbacks that should never be called with common.fail(). PR-URL: https://github.com/nodejs/node/pull/7753 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
24 lines
636 B
JavaScript
24 lines
636 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
var assert = require('assert');
|
|
var net = require('net');
|
|
var http = require('http');
|
|
|
|
var server = net.createServer(function(socket) {
|
|
// Neither Content-Length nor Connection
|
|
socket.end('HTTP/1.1 200 ok\r\n\r\nHello');
|
|
}).listen(0, common.mustCall(function() {
|
|
http.get({port: this.address().port}, common.mustCall(function(res) {
|
|
var body = '';
|
|
|
|
res.setEncoding('utf8');
|
|
res.on('data', function(chunk) {
|
|
body += chunk;
|
|
});
|
|
res.on('end', common.mustCall(function() {
|
|
assert.strictEqual(body, 'Hello');
|
|
server.close();
|
|
}));
|
|
}));
|
|
}));
|