mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 03:56:02 +00:00
04b4d15b39
Many of the tests use variables to track when callback functions are invoked or events are emitted. These variables are then asserted on process exit. This commit replaces this pattern in straightforward cases with common.mustCall(). This makes the tests easier to reason about, leads to a net reduction in lines of code, and uncovered a few bugs in tests. This commit also replaces some callbacks that should never be called with common.fail(). PR-URL: https://github.com/nodejs/node/pull/7753 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
32 lines
797 B
JavaScript
32 lines
797 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
// Make sure that throwing in 'end' handler doesn't lock
|
|
// up the socket forever.
|
|
//
|
|
// This is NOT a good way to handle errors in general, but all
|
|
// the same, we should not be so brittle and easily broken.
|
|
|
|
const http = require('http');
|
|
|
|
let n = 0;
|
|
const server = http.createServer((req, res) => {
|
|
if (++n === 10) server.close();
|
|
res.end('ok');
|
|
});
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
for (let i = 0; i < 10; i++) {
|
|
const options = { port: server.address().port };
|
|
const req = http.request(options, (res) => {
|
|
res.resume();
|
|
res.on('end', common.mustCall(() => {
|
|
throw new Error('gleep glorp');
|
|
}));
|
|
});
|
|
req.end();
|
|
}
|
|
}));
|
|
|
|
process.on('uncaughtException', common.mustCall(() => {}, 10));
|