mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 17:03:34 +00:00
04b4d15b39
Many of the tests use variables to track when callback functions are invoked or events are emitted. These variables are then asserted on process exit. This commit replaces this pattern in straightforward cases with common.mustCall(). This makes the tests easier to reason about, leads to a net reduction in lines of code, and uncovered a few bugs in tests. This commit also replaces some callbacks that should never be called with common.fail(). PR-URL: https://github.com/nodejs/node/pull/7753 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
69 lines
1.9 KiB
JavaScript
69 lines
1.9 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
|
|
const server = http.createServer(common.fail);
|
|
server.on('connect', common.mustCall(function(req, socket, firstBodyChunk) {
|
|
assert.equal(req.method, 'CONNECT');
|
|
assert.equal(req.url, 'example.com:443');
|
|
console.error('Server got CONNECT request');
|
|
|
|
// It is legal for the server to send some data intended for the client
|
|
// along with the CONNECT response
|
|
socket.write(
|
|
'HTTP/1.1 200 Connection established\r\n' +
|
|
'Date: Tue, 15 Nov 1994 08:12:31 GMT\r\n' +
|
|
'\r\n' +
|
|
'Head'
|
|
);
|
|
|
|
var data = firstBodyChunk.toString();
|
|
socket.on('data', function(buf) {
|
|
data += buf.toString();
|
|
});
|
|
socket.on('end', function() {
|
|
socket.end(data);
|
|
});
|
|
}));
|
|
server.listen(0, common.mustCall(function() {
|
|
const req = http.request({
|
|
port: this.address().port,
|
|
method: 'CONNECT',
|
|
path: 'example.com:443'
|
|
}, common.fail);
|
|
|
|
req.on('close', common.mustCall(function() { }));
|
|
|
|
req.on('connect', common.mustCall(function(res, socket, firstBodyChunk) {
|
|
console.error('Client got CONNECT request');
|
|
|
|
// Make sure this request got removed from the pool.
|
|
const name = 'localhost:' + server.address().port;
|
|
assert(!http.globalAgent.sockets.hasOwnProperty(name));
|
|
assert(!http.globalAgent.requests.hasOwnProperty(name));
|
|
|
|
// Make sure this socket has detached.
|
|
assert(!socket.ondata);
|
|
assert(!socket.onend);
|
|
assert.equal(socket.listeners('connect').length, 0);
|
|
assert.equal(socket.listeners('data').length, 0);
|
|
|
|
var data = firstBodyChunk.toString();
|
|
|
|
// test that the firstBodyChunk was not parsed as HTTP
|
|
assert.equal(data, 'Head');
|
|
|
|
socket.on('data', function(buf) {
|
|
data += buf.toString();
|
|
});
|
|
socket.on('end', function() {
|
|
assert.equal(data, 'HeadRequestEnd');
|
|
server.close();
|
|
});
|
|
socket.end('End');
|
|
}));
|
|
|
|
req.end('Request');
|
|
}));
|