mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 15:41:06 +00:00
04b4d15b39
Many of the tests use variables to track when callback functions are invoked or events are emitted. These variables are then asserted on process exit. This commit replaces this pattern in straightforward cases with common.mustCall(). This makes the tests easier to reason about, leads to a net reduction in lines of code, and uncovered a few bugs in tests. This commit also replaces some callbacks that should never be called with common.fail(). PR-URL: https://github.com/nodejs/node/pull/7753 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
35 lines
933 B
JavaScript
35 lines
933 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
var assert = require('assert');
|
|
var http = require('http');
|
|
|
|
var body = 'hello world\n';
|
|
|
|
var httpServer = http.createServer(common.mustCall(function(req, res) {
|
|
httpServer.close();
|
|
|
|
res.on('finish', common.mustCall(function() {
|
|
assert(typeof req.connection.bytesWritten === 'number');
|
|
assert(req.connection.bytesWritten > 0);
|
|
}));
|
|
res.writeHead(200, { 'Content-Type': 'text/plain' });
|
|
|
|
// Write 1.5mb to cause some requests to buffer
|
|
// Also, mix up the encodings a bit.
|
|
var chunk = new Array(1024 + 1).join('7');
|
|
var bchunk = Buffer.from(chunk);
|
|
for (var i = 0; i < 1024; i++) {
|
|
res.write(chunk);
|
|
res.write(bchunk);
|
|
res.write(chunk, 'hex');
|
|
}
|
|
// Get .bytesWritten while buffer is not empty
|
|
assert(res.connection.bytesWritten > 0);
|
|
|
|
res.end(body);
|
|
}));
|
|
|
|
httpServer.listen(0, function() {
|
|
http.get({ port: this.address().port });
|
|
});
|