mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 15:41:06 +00:00
04b4d15b39
Many of the tests use variables to track when callback functions are invoked or events are emitted. These variables are then asserted on process exit. This commit replaces this pattern in straightforward cases with common.mustCall(). This makes the tests easier to reason about, leads to a net reduction in lines of code, and uncovered a few bugs in tests. This commit also replaces some callbacks that should never be called with common.fail(). PR-URL: https://github.com/nodejs/node/pull/7753 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
90 lines
2.8 KiB
JavaScript
90 lines
2.8 KiB
JavaScript
'use strict';
|
||
var common = require('../common');
|
||
var assert = require('assert');
|
||
var fs = require('fs');
|
||
var join = require('path').join;
|
||
|
||
common.refreshTmpDir();
|
||
|
||
var filename = join(common.tmpDir, 'test.txt');
|
||
|
||
var n = 220;
|
||
var s = '南越国是前203年至前111年存在于岭南地区的一个国家，国都位于番禺，疆域包括今天中国的广东、' +
|
||
'广西两省区的大部份地区，福建省、湖南、贵州、云南的一小部份地区和越南的北部。' +
|
||
'南越国是秦朝灭亡后，由南海郡尉赵佗于前203年起兵兼并桂林郡和象郡后建立。' +
|
||
'前196年和前179年，南越国曾先后两次名义上臣属于西汉，成为西汉的“外臣”。前112年，' +
|
||
'南越国末代君主赵建德与西汉发生战争，被汉武帝于前111年所灭。南越国共存在93年，' +
|
||
'历经五代君主。南越国是岭南地区的第一个有记载的政权国家，采用封建制和郡县制并存的制度，' +
|
||
'它的建立保证了秦末乱世岭南地区社会秩序的稳定，有效的改善了岭南地区落后的政治、##济现状。\n';
|
||
|
||
fs.writeFile(filename, s, common.mustCall(function(e) {
|
||
if (e) throw e;
|
||
|
||
fs.readFile(filename, common.mustCall(function(e, buffer) {
|
||
if (e) throw e;
|
||
assert.equal(Buffer.byteLength(s), buffer.length);
|
||
}));
|
||
}));
|
||
|
||
// test that writeFile accepts buffers
|
||
var filename2 = join(common.tmpDir, 'test2.txt');
|
||
var buf = Buffer.from(s, 'utf8');
|
||
|
||
fs.writeFile(filename2, buf, common.mustCall(function(e) {
|
||
if (e) throw e;
|
||
|
||
fs.readFile(filename2, common.mustCall(function(e, buffer) {
|
||
if (e) throw e;
|
||
|
||
assert.equal(buf.length, buffer.length);
|
||
}));
|
||
}));
|
||
|
||
// test that writeFile accepts numbers.
|
||
var filename3 = join(common.tmpDir, 'test3.txt');
|
||
|
||
var m = 0o600;
|
||
fs.writeFile(filename3, n, { mode: m }, common.mustCall(function(e) {
|
||
if (e) throw e;
|
||
|
||
// windows permissions aren't unix
|
||
if (!common.isWindows) {
|
||
var st = fs.statSync(filename3);
|
||
assert.equal(st.mode & 0o700, m);
|
||
}
|
||
|
||
fs.readFile(filename3, common.mustCall(function(e, buffer) {
|
||
if (e) throw e;
|
||
|
||
assert.equal(Buffer.byteLength('' + n), buffer.length);
|
||
}));
|
||
}));
|
||
|
||
// test that writeFile accepts file descriptors
|
||
var filename4 = join(common.tmpDir, 'test4.txt');
|
||
|
||
fs.open(filename4, 'w+', common.mustCall(function(e, fd) {
|
||
if (e) throw e;
|
||
|
||
fs.writeFile(fd, s, common.mustCall(function(e) {
|
||
if (e) throw e;
|
||
|
||
fs.close(fd, common.mustCall(function(e) {
|
||
if (e) throw e;
|
||
|
||
fs.readFile(filename4, common.mustCall(function(e, buffer) {
|
||
if (e) throw e;
|
||
|
||
assert.equal(Buffer.byteLength(s), buffer.length);
|
||
}));
|
||
}));
|
||
}));
|
||
}));
|
||
|
||
process.on('exit', function() {
|
||
fs.unlinkSync(filename);
|
||
fs.unlinkSync(filename2);
|
||
fs.unlinkSync(filename3);
|
||
fs.unlinkSync(filename4);
|
||
});
|