node/test/parallel/test-zlib-from-gzip-with-trailing-garbage.js
Michael Lefkowitz 39c4af580c test: improve zlib-from-gzip-with-trailing-garbage
* use assert.strictEqual instead of assert.equal
* add RegExp in second argument of assert.throws
* validate error message and code

PR-URL: https://github.com/nodejs/node/pull/10674
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2017-01-09 21:08:41 -08:00

66 lines
1.6 KiB
JavaScript

'use strict';
// test unzipping a gzip file that has trailing garbage
const common = require('../common');
const assert = require('assert');
const zlib = require('zlib');
// should ignore trailing null-bytes
let data = Buffer.concat([
zlib.gzipSync('abc'),
zlib.gzipSync('def'),
Buffer(10).fill(0)
]);
assert.strictEqual(zlib.gunzipSync(data).toString(), 'abcdef');
zlib.gunzip(data, common.mustCall((err, result) => {
assert.ifError(err);
assert.strictEqual(
result.toString(),
'abcdef',
'result should match original string'
);
}));
// if the trailing garbage happens to look like a gzip header, it should
// throw an error.
data = Buffer.concat([
zlib.gzipSync('abc'),
zlib.gzipSync('def'),
Buffer([0x1f, 0x8b, 0xff, 0xff]),
Buffer(10).fill(0)
]);
assert.throws(
() => zlib.gunzipSync(data),
/^Error: unknown compression method$/
);
zlib.gunzip(data, common.mustCall((err, result) => {
assert(err instanceof Error);
assert.strictEqual(err.code, 'Z_DATA_ERROR');
assert.strictEqual(err.message, 'unknown compression method');
assert.strictEqual(result, undefined);
}));
// In this case the trailing junk is too short to be a gzip segment
// So we ignore it and decompression succeeds.
data = Buffer.concat([
zlib.gzipSync('abc'),
zlib.gzipSync('def'),
Buffer([0x1f, 0x8b, 0xff, 0xff])
]);
assert.throws(
() => zlib.gunzipSync(data),
/^Error: unknown compression method$/
);
zlib.gunzip(data, common.mustCall((err, result) => {
assert(err instanceof Error);
assert.strictEqual(err.code, 'Z_DATA_ERROR');
assert.strictEqual(err.message, 'unknown compression method');
assert.strictEqual(result, undefined);
}));