node/test/parallel/test-http-client-check-http-token.js
Luca Maraschi df3978421b http: verify client method is a string
Prior to this commit, it was possible to pass a truthy non-string
value as the HTTP method to the HTTP client, resulting in an
exception being thrown. This commit adds validation to the method.

PR-URL: https://github.com/nodejs/node/pull/10111
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2016-12-08 09:51:07 -05:00

41 lines
817 B
JavaScript

'use strict';
const common = require('../common');
const assert = require('assert');
const http = require('http');
const expectedSuccesses = [undefined, null, 'GET', 'post'];
let requestCount = 0;
const server = http.createServer((req, res) => {
requestCount++;
res.end();
if (expectedSuccesses.length === requestCount) {
server.close();
}
}).listen(0, test);
function test() {
function fail(input) {
assert.throws(() => {
http.request({ method: input, path: '/' }, common.fail);
}, /^TypeError: Method must be a string$/);
}
fail(-1);
fail(1);
fail(0);
fail({});
fail(true);
fail(false);
fail([]);
function ok(method) {
http.request({ method: method, port: server.address().port }).end();
}
expectedSuccesses.forEach((method) => {
ok(method);
});
}