mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 23:52:40 +00:00
152bd82de9
1. The test doesn't attach an event listener for `exit` events and removes them before killing. The intention is to fail the tests if the processes exit normally. This patch attaches the `exit` event handlers. 2. Replace `var`s with `let`s and `const`s. 3. Replace `==` based assertion with `strictEqual` assertion. 4. Use `common.PORT` instead of `5959`. 5. The test used to expect only one string "connecting to localhost:5959 ... ok", but the debugger actually emits another string, "break in test/fixtures/empty.js:2". This patch asserts if both of them are received in the same order. Refer: https://github.com/nodejs/node/issues/10361 PR-URL: https://github.com/nodejs/node/pull/10455 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
62 lines
1.8 KiB
JavaScript
62 lines
1.8 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const spawn = require('child_process').spawn;
|
|
const path = require('path');
|
|
|
|
const PORT = common.PORT;
|
|
const scriptToDebug = path.join(common.fixturesDir, 'empty.js');
|
|
|
|
// running with debug agent
|
|
const child = spawn(process.execPath, [`--debug-brk=${PORT}`, scriptToDebug]);
|
|
|
|
// connect to debug agent
|
|
const interfacer = spawn(process.execPath, ['debug', `localhost:${PORT}`]);
|
|
interfacer.stdout.setEncoding('utf-8');
|
|
|
|
// fail the test if either of the processes exit normally
|
|
const debugBreakExit = common.fail.bind(null, 'child should not exit normally');
|
|
const debugExit = common.fail.bind(null, 'interfacer should not exit normally');
|
|
child.on('exit', debugBreakExit);
|
|
interfacer.on('exit', debugExit);
|
|
|
|
let buffer = '';
|
|
const expected = [
|
|
`\bconnecting to localhost:${PORT} ... ok`,
|
|
'\bbreak in test/fixtures/empty.js:2'
|
|
];
|
|
const actual = [];
|
|
interfacer.stdout.on('data', function(data) {
|
|
data = (buffer + data).split('\n');
|
|
buffer = data.pop();
|
|
data.forEach(function(line) {
|
|
interfacer.emit('line', line);
|
|
});
|
|
});
|
|
|
|
interfacer.on('line', function(line) {
|
|
line = line.replace(/^(debug> *)+/, '');
|
|
if (expected.includes(line)) {
|
|
actual.push(line);
|
|
}
|
|
});
|
|
|
|
// allow time to start up the debugger
|
|
setTimeout(function() {
|
|
// remove the exit handlers before killing the processes
|
|
child.removeListener('exit', debugBreakExit);
|
|
interfacer.removeListener('exit', debugExit);
|
|
|
|
child.kill();
|
|
interfacer.kill();
|
|
}, common.platformTimeout(2000));
|
|
|
|
process.on('exit', function() {
|
|
// additional checks to ensure that both the processes were actually killed
|
|
assert(child.killed);
|
|
assert(interfacer.killed);
|
|
assert.deepStrictEqual(actual, expected);
|
|
});
|
|
|
|
interfacer.stderr.pipe(process.stderr);
|