mirror of
https://github.com/nodejs/node.git
synced 2025-05-17 18:26:24 +00:00
827ee498e3
Neuter external `nullptr` buffers, otherwise their contents will be
materialized on access, and the buffer instance will be internalized.
This leads to a crash like this:
v8::ArrayBuffer::Neuter Only externalized ArrayBuffers can be
neutered
Fix: #3619
PR-URL: https://github.com/nodejs/node/pull/3624
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
41 lines
814 B
C++
41 lines
814 B
C++
#include <node.h>
|
|
#include <node_buffer.h>
|
|
#include <util.h>
|
|
#include <v8.h>
|
|
|
|
static int alive;
|
|
|
|
static void FreeCallback(char* data, void* hint) {
|
|
CHECK_EQ(data, nullptr);
|
|
alive--;
|
|
}
|
|
|
|
void Run(const v8::FunctionCallbackInfo<v8::Value>& args) {
|
|
v8::Isolate* isolate = args.GetIsolate();
|
|
alive++;
|
|
|
|
{
|
|
v8::HandleScope scope(isolate);
|
|
v8::Local<v8::Object> buf = node::Buffer::New(
|
|
isolate,
|
|
nullptr,
|
|
0,
|
|
FreeCallback,
|
|
nullptr).ToLocalChecked();
|
|
|
|
char* data = node::Buffer::Data(buf);
|
|
CHECK_EQ(data, nullptr);
|
|
}
|
|
|
|
isolate->RequestGarbageCollectionForTesting(
|
|
v8::Isolate::kFullGarbageCollection);
|
|
|
|
CHECK_EQ(alive, 0);
|
|
}
|
|
|
|
void init(v8::Local<v8::Object> target) {
|
|
NODE_SET_METHOD(target, "run", Run);
|
|
}
|
|
|
|
NODE_MODULE(binding, init);
|