mirror of
https://github.com/nodejs/node.git
synced 2025-05-17 18:26:24 +00:00
35f2f64edd
In preparation for a lint rule that will enforce `throw new Error()` over `throw Error()`, fix the handful of instances in the code that use `throw Error()`. PR-URL: https://github.com/nodejs/node/pull/3714 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
62 lines
1.6 KiB
JavaScript
62 lines
1.6 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../../common');
|
|
const assert = require('assert');
|
|
const vm = require('vm');
|
|
const binding = require('./build/Release/binding');
|
|
const makeCallback = binding.makeCallback;
|
|
|
|
assert.strictEqual(42, makeCallback(process, common.mustCall(function() {
|
|
assert.strictEqual(0, arguments.length);
|
|
assert.strictEqual(this, process);
|
|
return 42;
|
|
})));
|
|
|
|
assert.strictEqual(42, makeCallback(process, common.mustCall(function(x) {
|
|
assert.strictEqual(1, arguments.length);
|
|
assert.strictEqual(this, process);
|
|
assert.strictEqual(x, 1337);
|
|
return 42;
|
|
}), 1337));
|
|
|
|
const recv = {
|
|
one: common.mustCall(function() {
|
|
assert.strictEqual(0, arguments.length);
|
|
assert.strictEqual(this, recv);
|
|
return 42;
|
|
}),
|
|
two: common.mustCall(function(x) {
|
|
assert.strictEqual(1, arguments.length);
|
|
assert.strictEqual(this, recv);
|
|
assert.strictEqual(x, 1337);
|
|
return 42;
|
|
}),
|
|
};
|
|
|
|
assert.strictEqual(42, makeCallback(recv, 'one'));
|
|
assert.strictEqual(42, makeCallback(recv, 'two', 1337));
|
|
|
|
// Check that the callback is made in the context of the receiver.
|
|
const target = vm.runInNewContext(`
|
|
(function($Object) {
|
|
if (Object === $Object)
|
|
throw new Error('bad');
|
|
return Object;
|
|
})
|
|
`);
|
|
assert.notStrictEqual(Object, makeCallback(process, target, Object));
|
|
|
|
// Runs in inner context.
|
|
const forward = vm.runInNewContext(`
|
|
(function(forward) {
|
|
return forward(Object);
|
|
})
|
|
`);
|
|
// Runs in outer context.
|
|
const endpoint = function($Object) {
|
|
if (Object === $Object)
|
|
throw new Error('bad');
|
|
return Object;
|
|
};
|
|
assert.strictEqual(Object, makeCallback(process, forward, endpoint));
|