mirror of
https://github.com/nodejs/node.git
synced 2025-05-04 15:02:25 +00:00
0142276977
Start the transition to Array.prototype.includes() and String.prototype.includes(). This commit refactors most of the comparisons of Array.prototype.indexOf() and String.prototype.indexOf() return values with -1 to the former methods in tests. PR-URL: https://github.com/nodejs/node/pull/12604 Refs: https://github.com/nodejs/node/issues/12586 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
85 lines
3.0 KiB
JavaScript
85 lines
3.0 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const exec = require('child_process').exec;
|
|
const path = require('path');
|
|
|
|
function errExec(script, callback) {
|
|
const cmd = '"' + process.argv[0] + '" "' +
|
|
path.join(common.fixturesDir, script) + '"';
|
|
return exec(cmd, function(err, stdout, stderr) {
|
|
// There was some error
|
|
assert.ok(err);
|
|
|
|
// More than one line of error output.
|
|
assert.ok(stderr.split('\n').length > 2);
|
|
|
|
// Assert the script is mentioned in error output.
|
|
assert.ok(stderr.includes(script));
|
|
|
|
// Proxy the args for more tests.
|
|
callback(err, stdout, stderr);
|
|
});
|
|
}
|
|
|
|
|
|
// Simple throw error
|
|
errExec('throws_error.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(/blah/.test(stderr));
|
|
}));
|
|
|
|
|
|
// Trying to JSON.parse(undefined)
|
|
errExec('throws_error2.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(/SyntaxError/.test(stderr));
|
|
}));
|
|
|
|
|
|
// Trying to JSON.parse(undefined) in nextTick
|
|
errExec('throws_error3.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(/SyntaxError/.test(stderr));
|
|
}));
|
|
|
|
|
|
// throw ILLEGAL error
|
|
errExec('throws_error4.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(/\/\*\*/.test(stderr));
|
|
assert.ok(/SyntaxError/.test(stderr));
|
|
}));
|
|
|
|
// Specific long exception line doesn't result in stack overflow
|
|
errExec('throws_error5.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(/SyntaxError/.test(stderr));
|
|
}));
|
|
|
|
// Long exception line with length > errorBuffer doesn't result in assertion
|
|
errExec('throws_error6.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(/SyntaxError/.test(stderr));
|
|
}));
|
|
|
|
// Object that throws in toString() doesn't print garbage
|
|
errExec('throws_error7.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(/<toString\(\) threw exception/.test(stderr));
|
|
}));
|