mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 14:25:18 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
49 lines
1.2 KiB
JavaScript
49 lines
1.2 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const zlib = require('zlib');
|
|
|
|
zlib.createGzip({ flush: zlib.constants.Z_SYNC_FLUSH });
|
|
|
|
assert.throws(
|
|
() => zlib.createGzip({ flush: 'foobar' }),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "options.flush" property must be of type number. ' +
|
|
"Received type string ('foobar')"
|
|
}
|
|
);
|
|
|
|
assert.throws(
|
|
() => zlib.createGzip({ flush: 10000 }),
|
|
{
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "options.flush" is out of range. It must ' +
|
|
'be >= 0 and <= 5. Received 10000'
|
|
}
|
|
);
|
|
|
|
zlib.createGzip({ finishFlush: zlib.constants.Z_SYNC_FLUSH });
|
|
|
|
assert.throws(
|
|
() => zlib.createGzip({ finishFlush: 'foobar' }),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "options.finishFlush" property must be of type number. ' +
|
|
"Received type string ('foobar')"
|
|
}
|
|
);
|
|
|
|
assert.throws(
|
|
() => zlib.createGzip({ finishFlush: 10000 }),
|
|
{
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "options.finishFlush" is out of range. It must ' +
|
|
'be >= 0 and <= 5. Received 10000'
|
|
}
|
|
);
|