mirror of
https://github.com/nodejs/node.git
synced 2025-04-28 13:40:37 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
102 lines
1.8 KiB
JavaScript
102 lines
1.8 KiB
JavaScript
'use strict';
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
const { createContext, runInContext, runInNewContext } = require('vm');
|
|
|
|
const WASM_BYTES = Buffer.from(
|
|
[0x00, 0x61, 0x73, 0x6d, 0x01, 0x00, 0x00, 0x00]);
|
|
|
|
{
|
|
const ctx = createContext({ WASM_BYTES });
|
|
const test = 'eval(""); new WebAssembly.Module(WASM_BYTES);';
|
|
runInContext(test, ctx);
|
|
|
|
runInNewContext(test, { WASM_BYTES }, {
|
|
contextCodeGeneration: undefined,
|
|
});
|
|
}
|
|
|
|
{
|
|
const ctx = createContext({}, {
|
|
codeGeneration: {
|
|
strings: false,
|
|
},
|
|
});
|
|
|
|
const EvalError = runInContext('EvalError', ctx);
|
|
assert.throws(() => {
|
|
runInContext('eval("x")', ctx);
|
|
}, EvalError);
|
|
}
|
|
|
|
{
|
|
const ctx = createContext({ WASM_BYTES }, {
|
|
codeGeneration: {
|
|
wasm: false,
|
|
},
|
|
});
|
|
|
|
const CompileError = runInContext('WebAssembly.CompileError', ctx);
|
|
assert.throws(() => {
|
|
runInContext('new WebAssembly.Module(WASM_BYTES)', ctx);
|
|
}, CompileError);
|
|
}
|
|
|
|
assert.throws(() => {
|
|
runInNewContext('eval("x")', {}, {
|
|
contextCodeGeneration: {
|
|
strings: false,
|
|
},
|
|
});
|
|
}, {
|
|
name: 'EvalError'
|
|
});
|
|
|
|
assert.throws(() => {
|
|
runInNewContext('new WebAssembly.Module(WASM_BYTES)', { WASM_BYTES }, {
|
|
contextCodeGeneration: {
|
|
wasm: false,
|
|
},
|
|
});
|
|
}, {
|
|
name: 'CompileError'
|
|
});
|
|
|
|
assert.throws(() => {
|
|
createContext({}, {
|
|
codeGeneration: {
|
|
strings: 0,
|
|
},
|
|
});
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
});
|
|
|
|
assert.throws(() => {
|
|
runInNewContext('eval("x")', {}, {
|
|
contextCodeGeneration: {
|
|
wasm: 1,
|
|
},
|
|
});
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE'
|
|
});
|
|
|
|
assert.throws(() => {
|
|
createContext({}, {
|
|
codeGeneration: 1,
|
|
});
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
});
|
|
|
|
assert.throws(() => {
|
|
createContext({}, {
|
|
codeGeneration: null,
|
|
});
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
});
|