mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 06:19:07 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
36 lines
800 B
JavaScript
36 lines
800 B
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
const common = require('../common');
|
|
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
// Monkey-patch SecureContext
|
|
const { internalBinding } = require('internal/test/binding');
|
|
const binding = internalBinding('crypto');
|
|
const NativeSecureContext = binding.SecureContext;
|
|
|
|
binding.SecureContext = function() {
|
|
const rv = new NativeSecureContext();
|
|
rv.setEngineKey = undefined;
|
|
return rv;
|
|
};
|
|
|
|
const tls = require('tls');
|
|
|
|
{
|
|
assert.throws(
|
|
() => {
|
|
tls.createSecureContext({
|
|
privateKeyEngine: 'engine',
|
|
privateKeyIdentifier: 'key'
|
|
});
|
|
},
|
|
{
|
|
code: 'ERR_CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED',
|
|
message: 'Custom engines not supported by this OpenSSL'
|
|
}
|
|
);
|
|
}
|