mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 00:30:06 +00:00
8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
14 lines
427 B
JavaScript
14 lines
427 B
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (!isMainThread) {
|
|
// Note that test-timers-immediate-unref-nested-once works instead.
|
|
common.skip('Worker bootstrapping works differently -> different timing');
|
|
}
|
|
|
|
// This immediate should not execute as it was unrefed
|
|
// and nothing else is keeping the event loop alive
|
|
setImmediate(common.mustNotCall()).unref();
|