mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 22:40:57 +00:00

Make virtual methods throw an ERR_METHOD_NOT_IMPLEMENTED error instead of emitting it. The error is not recoverable and the only way to handle it is to override the method. PR-URL: https://github.com/nodejs/node/pull/31912 Refs: https://github.com/nodejs/node/pull/31818#pullrequestreview-359403469 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
44 lines
795 B
JavaScript
44 lines
795 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
const assert = require('assert');
|
|
const { Transform } = require('stream');
|
|
|
|
const t = new Transform();
|
|
|
|
assert.throws(
|
|
() => {
|
|
t.end(Buffer.from('blerg'));
|
|
},
|
|
{
|
|
name: 'Error',
|
|
code: 'ERR_METHOD_NOT_IMPLEMENTED',
|
|
message: 'The _transform() method is not implemented'
|
|
}
|
|
);
|
|
|
|
const _transform = common.mustCall((chunk, _, next) => {
|
|
next();
|
|
});
|
|
|
|
const _final = common.mustCall((next) => {
|
|
next();
|
|
});
|
|
|
|
const _flush = common.mustCall((next) => {
|
|
next();
|
|
});
|
|
|
|
const t2 = new Transform({
|
|
transform: _transform,
|
|
flush: _flush,
|
|
final: _final
|
|
});
|
|
|
|
assert.strictEqual(t2._transform, _transform);
|
|
assert.strictEqual(t2._flush, _flush);
|
|
assert.strictEqual(t2._final, _final);
|
|
|
|
t2.end(Buffer.from('blerg'));
|
|
t2.resume();
|