mirror of
https://github.com/nodejs/node.git
synced 2025-04-28 13:40:37 +00:00

There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
58 lines
1.7 KiB
JavaScript
58 lines
1.7 KiB
JavaScript
'use strict';
|
|
// Original test written by Jakub Lekstan <kuebzky@gmail.com>
|
|
const common = require('../common');
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
// FIXME add sunos support
|
|
if (common.isSunOS || common.isIBMi) {
|
|
common.skip(`Unsupported platform [${process.platform}]`);
|
|
}
|
|
|
|
if (!isMainThread) {
|
|
common.skip('Setting the process title from Workers is not supported');
|
|
}
|
|
|
|
const assert = require('assert');
|
|
const { exec, execSync } = require('child_process');
|
|
const path = require('path');
|
|
|
|
// The title shouldn't be too long; libuv's uv_set_process_title() out of
|
|
// security considerations no longer overwrites envp, only argv, so the
|
|
// maximum title length is possibly quite short.
|
|
let title = String(process.pid);
|
|
|
|
assert.notStrictEqual(process.title, title);
|
|
process.title = title;
|
|
assert.strictEqual(process.title, title);
|
|
|
|
// Test setting the title but do not try to run `ps` on Windows.
|
|
if (common.isWindows) {
|
|
common.skip('Windows does not have "ps" utility');
|
|
}
|
|
|
|
try {
|
|
execSync('command -v ps');
|
|
} catch (err) {
|
|
if (err.status === 1) {
|
|
common.skip('The "ps" utility is not available');
|
|
}
|
|
throw err;
|
|
}
|
|
|
|
// To pass this test on alpine, since Busybox `ps` does not
|
|
// support `-p` switch, use `ps -o` and `grep` instead.
|
|
const cmd = common.isLinux ?
|
|
`ps -o pid,args | grep '${process.pid} ${title}' | grep -v grep` :
|
|
`ps -p ${process.pid} -o args=`;
|
|
|
|
exec(cmd, common.mustSucceed((stdout, stderr) => {
|
|
assert.strictEqual(stderr, '');
|
|
|
|
// Freebsd always add ' (procname)' to the process title
|
|
if (common.isFreeBSD || common.isOpenBSD)
|
|
title += ` (${path.basename(process.execPath)})`;
|
|
|
|
// Omitting trailing whitespace and \n
|
|
assert.strictEqual(stdout.replace(/\s+$/, '').endsWith(title), true);
|
|
}));
|