mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 06:19:07 +00:00
5dafb48f1a
Previously, `require.resolve()` could crash when: - The first parameter was a relative path and - The `paths` array contained non-string entries This commit fixes the issue by adding a check in `Module._findPath` to ensure all elements in `paths` are strings, and adding a validation in `stat` before calling `InternalModuleStat` to guard against non-string filenames. PR-URL: https://github.com/nodejs/node/pull/56942 Fixes: https://github.com/nodejs/node/issues/47698 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
19 lines
405 B
JavaScript
19 lines
405 B
JavaScript
'use strict';
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
// Test invalid `paths` entries: Ensure non-string entries throw an error
|
|
{
|
|
const paths = [1, false, null, undefined, () => {}, {}];
|
|
paths.forEach((value) => {
|
|
assert.throws(
|
|
() => require.resolve('.', { paths: [value] }),
|
|
{
|
|
name: 'TypeError',
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
}
|
|
);
|
|
});
|
|
}
|