mirror of
https://github.com/nodejs/node.git
synced 2025-04-28 21:46:48 +00:00
8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
49 lines
1.1 KiB
JavaScript
49 lines
1.1 KiB
JavaScript
'use strict';
|
||
|
||
const common = require('../common');
|
||
const assert = require('assert');
|
||
const PassThrough = require('stream').PassThrough;
|
||
const readline = require('readline');
|
||
|
||
if (process.env.TERM === 'dumb') {
|
||
common.skip('skipping - dumb terminal');
|
||
}
|
||
|
||
// Checks that tab completion still works
|
||
// when output column size is undefined
|
||
|
||
const iStream = new PassThrough();
|
||
const oStream = new PassThrough();
|
||
|
||
readline.createInterface({
|
||
terminal: true,
|
||
input: iStream,
|
||
output: oStream,
|
||
completer: function(line, cb) {
|
||
cb(null, [['process.stdout', 'process.stdin', 'process.stderr'], line]);
|
||
}
|
||
});
|
||
|
||
let output = '';
|
||
|
||
oStream.on('data', function(data) {
|
||
output += data;
|
||
});
|
||
|
||
oStream.on('end', common.mustCall(() => {
|
||
const expect = 'process.stdout\r\n' +
|
||
'process.stdin\r\n' +
|
||
'process.stderr';
|
||
assert.match(output, new RegExp(expect));
|
||
}));
|
||
|
||
iStream.write('process.s\t');
|
||
|
||
// Completion works.
|
||
assert.match(output, /process\.std\b/);
|
||
// Completion doesn’t show all results yet.
|
||
assert.doesNotMatch(output, /stdout/);
|
||
|
||
iStream.write('\t');
|
||
oStream.end();
|