mirror of
https://github.com/nodejs/node.git
synced 2025-04-28 13:40:37 +00:00
8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
34 lines
660 B
JavaScript
34 lines
660 B
JavaScript
'use strict';
|
|
|
|
// This tests that the lower bits of mode > 0o777 still works in
|
|
// process.umask()
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (!isMainThread)
|
|
common.skip('Setting process.umask is not supported in Workers');
|
|
|
|
let mask;
|
|
|
|
if (common.isWindows) {
|
|
mask = 0o600;
|
|
} else {
|
|
mask = 0o664;
|
|
}
|
|
|
|
const maskToIgnore = 0o10000;
|
|
|
|
const old = process.umask();
|
|
|
|
function test(input, output) {
|
|
process.umask(input);
|
|
assert.strictEqual(process.umask(), output);
|
|
|
|
process.umask(old);
|
|
}
|
|
|
|
test(mask | maskToIgnore, mask);
|
|
test((mask | maskToIgnore).toString(8), mask);
|