mirror of
https://github.com/nodejs/node.git
synced 2025-04-28 13:40:37 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
75 lines
2.5 KiB
JavaScript
75 lines
2.5 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
// The default behavior, return an Array "tuple" of numbers
|
|
const tuple = process.hrtime();
|
|
|
|
// Validate the default behavior
|
|
validateTuple(tuple);
|
|
|
|
// Validate that passing an existing tuple returns another valid tuple
|
|
validateTuple(process.hrtime(tuple));
|
|
|
|
// Test that only an Array may be passed to process.hrtime()
|
|
assert.throws(() => {
|
|
process.hrtime(1);
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "time" argument must be an instance of Array. Received type ' +
|
|
'number (1)'
|
|
});
|
|
assert.throws(() => {
|
|
process.hrtime([]);
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "time" is out of range. It must be 2. Received 0'
|
|
});
|
|
assert.throws(() => {
|
|
process.hrtime([1]);
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "time" is out of range. It must be 2. Received 1'
|
|
});
|
|
assert.throws(() => {
|
|
process.hrtime([1, 2, 3]);
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "time" is out of range. It must be 2. Received 3'
|
|
});
|
|
|
|
function validateTuple(tuple) {
|
|
assert(Array.isArray(tuple));
|
|
assert.strictEqual(tuple.length, 2);
|
|
assert(Number.isInteger(tuple[0]));
|
|
assert(Number.isInteger(tuple[1]));
|
|
}
|
|
|
|
const diff = process.hrtime([0, 1e9 - 1]);
|
|
assert(diff[1] >= 0); // https://github.com/nodejs/node/issues/4751
|