mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 14:25:18 +00:00
8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
63 lines
2.2 KiB
JavaScript
63 lines
2.2 KiB
JavaScript
import { hasCrypto, hasIntl } from '../common/index.mjs';
|
|
import assert from 'node:assert';
|
|
import { builtinModules } from 'node:module';
|
|
import { isMainThread } from 'node:worker_threads';
|
|
|
|
for (const invalid of [1, undefined, null, false, [], {}, () => {}, Symbol('test')]) {
|
|
assert.throws(() => process.getBuiltinModule(invalid), { code: 'ERR_INVALID_ARG_TYPE' });
|
|
}
|
|
|
|
for (const invalid of [
|
|
'invalid', 'test', 'sea', 'test/reporter', 'internal/bootstrap/realm',
|
|
'internal/deps/undici/undici', 'internal/util',
|
|
]) {
|
|
assert.strictEqual(process.getBuiltinModule(invalid), undefined);
|
|
}
|
|
|
|
// Check that createRequire()(id) returns the same thing as process.getBuiltinModule(id).
|
|
const require = process.getBuiltinModule('module').createRequire(import.meta.url);
|
|
const publicBuiltins = new Set(builtinModules);
|
|
|
|
// Remove built-ins not available in the current setup.
|
|
if (!isMainThread) {
|
|
publicBuiltins.delete('trace_events');
|
|
}
|
|
if (!hasCrypto) {
|
|
publicBuiltins.delete('crypto');
|
|
publicBuiltins.delete('tls');
|
|
publicBuiltins.delete('_tls_common');
|
|
publicBuiltins.delete('_tls_wrap');
|
|
publicBuiltins.delete('http2');
|
|
publicBuiltins.delete('https');
|
|
publicBuiltins.delete('inspector');
|
|
publicBuiltins.delete('inspector/promises');
|
|
}
|
|
if (!hasIntl) {
|
|
publicBuiltins.delete('inspector');
|
|
publicBuiltins.delete('trace_events');
|
|
}
|
|
// TODO(@jasnell): Remove this once node:quic graduates from unflagged.
|
|
publicBuiltins.delete('node:quic');
|
|
|
|
for (const id of publicBuiltins) {
|
|
assert.strictEqual(process.getBuiltinModule(id), require(id));
|
|
}
|
|
// Check that import(id).default returns the same thing as process.getBuiltinModule(id).
|
|
for (const id of publicBuiltins) {
|
|
if (!id.startsWith('node:')) {
|
|
const imported = await import(`node:${id}`);
|
|
assert.strictEqual(process.getBuiltinModule(id), imported.default);
|
|
}
|
|
}
|
|
|
|
// publicBuiltins does not include 'test' which requires the node: prefix.
|
|
const ids = publicBuiltins.add('test');
|
|
// Check that import(id).default returns the same thing as process.getBuiltinModule(id).
|
|
for (const id of ids) {
|
|
if (!id.startsWith('node:')) {
|
|
const prefixed = `node:${id}`;
|
|
const imported = await import(prefixed);
|
|
assert.strictEqual(process.getBuiltinModule(prefixed), imported.default);
|
|
}
|
|
}
|