mirror of
https://github.com/nodejs/node.git
synced 2025-04-28 13:40:37 +00:00
8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
47 lines
1.3 KiB
JavaScript
47 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (!isMainThread) {
|
|
common.skip('process.chdir is not available in Workers');
|
|
}
|
|
|
|
const tmpdir = require('../common/tmpdir');
|
|
|
|
process.chdir('..');
|
|
assert.notStrictEqual(process.cwd(), __dirname);
|
|
process.chdir(__dirname);
|
|
assert.strictEqual(process.cwd(), __dirname);
|
|
|
|
let dirName;
|
|
if (process.versions.icu) {
|
|
// ICU is available, use characters that could possibly be decomposed
|
|
dirName = 'weird \uc3a4\uc3ab\uc3af characters \u00e1\u00e2\u00e3';
|
|
} else {
|
|
// ICU is unavailable, use characters that can't be decomposed
|
|
dirName = 'weird \ud83d\udc04 characters \ud83d\udc05';
|
|
}
|
|
const dir = tmpdir.resolve(dirName);
|
|
|
|
// Make sure that the tmp directory is clean
|
|
tmpdir.refresh();
|
|
|
|
fs.mkdirSync(dir);
|
|
process.chdir(dir);
|
|
assert.strictEqual(process.cwd().normalize(), dir.normalize());
|
|
|
|
process.chdir('..');
|
|
assert.strictEqual(process.cwd().normalize(),
|
|
path.resolve(tmpdir.path).normalize());
|
|
|
|
const err = {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: /The "directory" argument must be of type string/
|
|
};
|
|
assert.throws(function() { process.chdir({}); }, err);
|
|
assert.throws(function() { process.chdir(); }, err);
|