mirror of
https://github.com/nodejs/node.git
synced 2025-04-28 13:40:37 +00:00
8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
129 lines
3.8 KiB
JavaScript
129 lines
3.8 KiB
JavaScript
// Flags: --permission --allow-fs-read=* --allow-child-process
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (!isMainThread) {
|
|
common.skip('This test only works on a main thread');
|
|
}
|
|
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const { spawnSync } = require('child_process');
|
|
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const commonPathWildcard = path.join(__filename, '../../common*');
|
|
const file = fixtures.path('permission', 'fs-wildcard.js');
|
|
|
|
let allowList = [];
|
|
|
|
if (common.isWindows) {
|
|
const { root } = path.parse(process.cwd());
|
|
const abs = (p) => path.join(root, p);
|
|
allowList = [
|
|
'tmp\\*',
|
|
'example\\foo*',
|
|
'example\\bar*',
|
|
'folder\\*',
|
|
'show',
|
|
'slower',
|
|
'slown',
|
|
'home\\foo\\*',
|
|
].map(abs);
|
|
const { status, stderr } = spawnSync(
|
|
process.execPath,
|
|
[
|
|
'--permission',
|
|
...allowList.flatMap((path) => ['--allow-fs-read', path]),
|
|
'-e',
|
|
`
|
|
const path = require('path');
|
|
const assert = require('assert');
|
|
const { root } = path.parse(process.cwd());
|
|
const abs = (p) => path.join(root, p);
|
|
assert.ok(!process.permission.has('fs.read', abs('slow')));
|
|
assert.ok(!process.permission.has('fs.read', abs('slows')));
|
|
assert.ok(process.permission.has('fs.read', abs('slown')));
|
|
assert.ok(process.permission.has('fs.read', abs('home\\\\foo')));
|
|
assert.ok(process.permission.has('fs.read', abs('home\\\\foo\\\\')));
|
|
assert.ok(!process.permission.has('fs.read', abs('home\\\\fo')));
|
|
`,
|
|
]
|
|
);
|
|
assert.strictEqual(status, 0, stderr.toString());
|
|
} else {
|
|
allowList = [
|
|
'/tmp/*',
|
|
'/example/foo*',
|
|
'/example/bar*',
|
|
'/folder/*',
|
|
'/show',
|
|
'/slower',
|
|
'/slown',
|
|
'/home/foo/*',
|
|
'/files/index.js',
|
|
'/files/index.json',
|
|
'/files/i',
|
|
];
|
|
const { status, stderr } = spawnSync(
|
|
process.execPath,
|
|
[
|
|
'--permission',
|
|
...allowList.flatMap((path) => ['--allow-fs-read', path]),
|
|
'-e',
|
|
`
|
|
const assert = require('assert')
|
|
assert.ok(!process.permission.has('fs.read', '/slow'));
|
|
assert.ok(!process.permission.has('fs.read', '/slows'));
|
|
assert.ok(process.permission.has('fs.read', '/slown'));
|
|
assert.ok(process.permission.has('fs.read', '/home/foo'));
|
|
assert.ok(process.permission.has('fs.read', '/home/foo/'));
|
|
assert.ok(!process.permission.has('fs.read', '/home/fo'));
|
|
assert.ok(process.permission.has('fs.read', '/files/index.js'));
|
|
assert.ok(process.permission.has('fs.read', '/files/index.json'));
|
|
assert.ok(!process.permission.has('fs.read', '/files/index.j'));
|
|
assert.ok(process.permission.has('fs.read', '/files/i'));
|
|
`,
|
|
]
|
|
);
|
|
assert.strictEqual(status, 0, stderr.toString());
|
|
}
|
|
|
|
{
|
|
const { status, stderr } = spawnSync(
|
|
process.execPath,
|
|
[
|
|
'--permission',
|
|
`--allow-fs-read=${file}`, `--allow-fs-read=${commonPathWildcard}`, ...allowList.flatMap((path) => ['--allow-fs-read', path]),
|
|
file,
|
|
],
|
|
);
|
|
assert.strictEqual(status, 0, stderr.toString());
|
|
}
|
|
|
|
{
|
|
if (!common.isWindows) {
|
|
const { status, stderr } = spawnSync(
|
|
process.execPath,
|
|
[
|
|
'--permission',
|
|
'--allow-fs-read=/a/b/*',
|
|
'--allow-fs-read=/a/b/d',
|
|
'--allow-fs-read=/etc/passwd.*',
|
|
'--allow-fs-read=/home/*.js',
|
|
'-e',
|
|
`
|
|
const assert = require('assert')
|
|
assert.ok(process.permission.has('fs.read', '/a/b/c'));
|
|
assert.ok(!process.permission.has('fs.read', '/a/c/c'));
|
|
assert.ok(!process.permission.has('fs.read', '/etc/passwd'));
|
|
assert.ok(process.permission.has('fs.read', '/home/another-file.md'));
|
|
`,
|
|
]
|
|
);
|
|
assert.strictEqual(status, 0, stderr.toString());
|
|
}
|
|
}
|