mirror of
https://github.com/nodejs/node.git
synced 2025-04-28 21:46:48 +00:00
8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
65 lines
1.6 KiB
JavaScript
65 lines
1.6 KiB
JavaScript
// Flags: --permission --allow-fs-read=* --allow-fs-write=* --allow-child-process
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (!isMainThread) {
|
|
common.skip('This test only works on a main thread');
|
|
}
|
|
|
|
const fixtures = require('../common/fixtures');
|
|
if (!common.canCreateSymLink()) {
|
|
common.skip('insufficient privileges');
|
|
}
|
|
if (!common.hasCrypto) {
|
|
common.skip('no crypto');
|
|
}
|
|
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const { spawnSync } = require('child_process');
|
|
const path = require('path');
|
|
const tmpdir = require('../common/tmpdir');
|
|
|
|
const file = fixtures.path('permission', 'fs-symlink.js');
|
|
const commonPathWildcard = path.join(__filename, '../../common*');
|
|
const blockedFile = fixtures.path('permission', 'deny', 'protected-file.md');
|
|
const blockedFolder = tmpdir.resolve('subdirectory');
|
|
const symlinkFromBlockedFile = tmpdir.resolve('example-symlink.md');
|
|
|
|
{
|
|
tmpdir.refresh();
|
|
fs.mkdirSync(blockedFolder);
|
|
}
|
|
|
|
{
|
|
// Symlink previously created
|
|
fs.symlinkSync(blockedFile, symlinkFromBlockedFile);
|
|
}
|
|
|
|
{
|
|
const { status, stderr } = spawnSync(
|
|
process.execPath,
|
|
[
|
|
'--permission',
|
|
`--allow-fs-read=${file}`, `--allow-fs-read=${commonPathWildcard}`, `--allow-fs-read=${symlinkFromBlockedFile}`,
|
|
`--allow-fs-write=${symlinkFromBlockedFile}`,
|
|
file,
|
|
],
|
|
{
|
|
env: {
|
|
...process.env,
|
|
BLOCKEDFOLDER: blockedFolder,
|
|
BLOCKEDFILE: blockedFile,
|
|
EXISTINGSYMLINK: symlinkFromBlockedFile,
|
|
},
|
|
}
|
|
);
|
|
assert.strictEqual(status, 0, stderr.toString());
|
|
}
|
|
|
|
{
|
|
tmpdir.refresh();
|
|
}
|